Prompt to kill locking processes when accepting#707
Merged
Conversation
When accepting a move fails because the files are locked (eg the snapshot is open in Word), show a dialog listing the locked files and locking processes instead of silently leaving the move pending. Options: Ignore, Kill and accept, Kill and accept all pending, or Always kill. Always kill persists to settings (AlwaysKillLockingProcesses) and is toggleable in the Options dialog, so future locks are killed without prompting. Existing per-tool KillLockingProcess (Word/Excel) still auto-kills without a prompt. Split FileLockKiller into GetLockingProcesses (names the processes for the dialog) and Kill; Tracker now re-adds a move kept pending so it can be retried.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When accepting a move fails because the files are locked (eg the snapshot is open in Word), show a dialog listing the locked files and locking processes instead of silently leaving the move pending. Options: Ignore, Kill and accept, Kill and accept all pending, or Always kill.
Always kill persists to settings (AlwaysKillLockingProcesses) and is toggleable in the Options dialog, so future locks are killed without prompting. Existing per-tool KillLockingProcess (Word/Excel) still auto-kills without a prompt.
Split FileLockKiller into GetLockingProcesses (names the processes for the dialog) and Kill; Tracker now re-adds a move kept pending so it can be retried.