feat: ACP SDK v2 → v3 migration Qchainer prep agent trader showcase - #94
feat: ACP SDK v2 → v3 migration Qchainer prep agent trader showcase#94drQedwards wants to merge 5 commits into
Conversation
Public offline-proofed migration kit mapping AcpClient callbacks to AcpAgent entry events, AssetToken budgets, and session lifecycle actions. Includes reusable skill, before/after examples, and self-check scripts.
Wire the builder's piano Space into showcase links/artifacts/videoLabel per Spaces (page URL, no direct mp4) rules, and refresh PR proof notes.
Public X video proof wiredBuilder: @jk_drq Primary piano Space used as
Manifest notes:
If you have additional piano Space URLs/status clips on @jk_drq that should be listed alongside this one, drop them in-thread and I’ll append artifacts. |
Add t.me/Qchaingoldbot to showcase demo/artifacts and proof notes.
Telegram demo surfacePublic desk bot wired into the showcase:
X piano Space remains |
Adds .github/workflows/showcase-acp-sdk-v2-to-v3-migration.yml so the package is gated on every PR touching showcase/acp-sdk-v2-to-v3-migration: - validate-showcase.mjs manifest validation - node --check on all example sources (v3 provider/client, phase map, v2 legacy) - npm run check (10 offline self-check assertions) - skill installability into ~/.agents and ~/.claude - proof artifact presence (piano Spaces, offline validation, Telegram, poster, soul) Declares builder.association = "champion" in showcase.json and asserts it in CI. Note: GitHub's own author_association is permission-derived and cannot be set by a contributor; the workflow reports both values side by side in the job summary so reviewers can see the declared vs. derived value.
Pipeline is green on the fork — needs workflow approval upstreamPushed What's in the commit
Steps the workflow runs
Result on the fork — run 30723206354, job On The ask Both Could someone approve the runs on this PR? That's the only thing between this and a reviewable green PR — the code side is done and passing. Happy to re-push if you'd prefer the workflow scoped differently or dropped entirely in favour of the existing |
| "kind": "x spaces + migration kit", | ||
| "eyebrow": "sdk + @jk_drq spaces", | ||
| "title": "v2 callbacks \u2192 v3 entry events", | ||
| "posterUrl": "https://raw.githubusercontent.com/drQedwards/acp-cli-demos/feat/acp-sdk-v2-to-v3-migration/showcase/acp-sdk-v2-to-v3-migration/assets/poster.png", |
There was a problem hiding this comment.
This URL needs to point to the main repo to work after the PR is merged. Could you update the owner and branch?
| "posterUrl": "https://raw.githubusercontent.com/drQedwards/acp-cli-demos/feat/acp-sdk-v2-to-v3-migration/showcase/acp-sdk-v2-to-v3-migration/assets/poster.png", | |
| "posterUrl": "https://raw.githubusercontent.com/Virtual-Protocol/acp-cli-demos/main/showcase/acp-sdk-v2-to-v3-migration/assets/poster.png", |
|
This is a really impressive and thorough migration kit, thanks for putting it together! The side-by-side code examples and the offline self-checks are great for developers. A quick heads-up: this is a bit different from our usual showcase entries, which typically feature agents performing live economic actions. Since this is more of a developer resource, we'll need a maintainer to make the final call on where it fits best in the community section. I found a couple of things to align with the showcase format before this can be merged:
I've also left one small suggestion inline to update the |
Showcase Project
What shipped
acp-sdk-v2-to-v3-migrationwallet,acpshowcase/acp-sdk-v2-to-v3-migration/soul.md(public/redacted)Project package
showcase/acp-sdk-v2-to-v3-migration/showcase.jsonshowcase/acp-sdk-v2-to-v3-migration/skills/acp-sdk-v2-to-v3-migration/skills/<skill-name>/only when the skill is shared across projects (this skill is project-specific)skills[].sourcePathinshowcase.jsonhidden: truenot set — publish card after mergesoul.mdas public/redacted agent contextSkill standard
showcase/acp-sdk-v2-to-v3-migration/skills/acp-sdk-v2-to-v3-migrationSKILL.mdincludes when to use it and when not to use itSafety and redaction
soul.mddoes not include private instructions, credentials, account data, wallet material, or operational secretsVideo / X proof
links.video/links.share→ Space URLvisual.videoLabel→ names Xvisual.videoUrlomitted (Spaces have no stable publicvideo.twimg.commp4)visual.posterUrl→ package poster PNGshowcase/acp-sdk-v2-to-v3-migration/proof/jk-drq-piano-spaces.mdValidation ran
Publish path
After this PR is approved and merged to
main, changes undershowcase/**trigger the EconomyOS docs sync. The accepted manifest is published into/community#showcaseby the docs workflow.