Skip to content

docs: clarify that trade accepts bare tickers, not just addresses #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
psmiratisu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: clarify that trade accepts bare tickers, not just addresses #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@ acp trade --token-in usdc --chain-in 1 --amount-in 100 --token-out usdc --chain-
acp trade --token-in usdc --chain-in 8453 --amount-in 5 --token-out sol
```

Supported chains: **Base (8453), Ethereum (1), BSC (56), Hyperliquid (1337), Solana** (+ Base Sepolia testnet). Token symbols `eth`, `weth`, `usdc`, `usdt`, `sol`, `virtual` are resolved automatically; anything else is taken as a token address.
Supported chains: **Base (8453), Ethereum (1), BSC (56), Hyperliquid (1337), Solana** (+ Base Sepolia testnet). The canonical symbols `eth`, `weth`, `usdc`, `usdt`, `sol`, `virtual` always resolve. Beyond those, a **buy** (`--token-out <TICKER>`) or **sell** (`--token-in <TICKER>`) accepts a bare ticker — the backend resolves it (a buy by highest 24h volume, filtering same-ticker scams; a sell against your holdings). Only a token→token swap with no dollar leg needs an explicit contract address for a non-canonical symbol.

**Hyperliquid — deposit (a cross-chain swap into HL, chain 1337):**

Expand Down
2 changes: 1 addition & 1 deletion SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ acp trade hl-status --json
acp trade withdraw-from-hl --amount 25 --json
```

Supported swap chains: Base (8453), Ethereum (1), BSC (56), Hyperliquid (1337), Solana (+ Base Sepolia testnet). Known token symbols: `eth`, `weth`, `usdc`, `usdt`, `sol`, `virtual`; anything else is treated as a token address.
Supported swap chains: Base (8453), Ethereum (1), BSC (56), Hyperliquid (1337), Solana (+ Base Sepolia testnet). The canonical symbols `eth`, `weth`, `usdc`, `usdt`, `sol`, `virtual` always resolve. Beyond those, the backend resolves a **bare ticker** for directional trades — a **buy** (a dollar/canonical/address `--token-in` → `--token-out <TICKER>`) picks the deployment with the highest 24h volume (which filters out same-ticker scams), and a **sell** (`--token-in <TICKER>` → a dollar `--token-out`) matches your wallet's holdings — so you needn't look up a contract address for those. Only a **token→token swap with no dollar leg** still needs an explicit contract address for a non-canonical symbol (a bare ticker there is ambiguous and is rejected with `AMBIGUOUS_SYMBOL`).

**Timing.** Same-chain swaps return in a few seconds. Cross-chain swaps and HL **deposits block until the bridge settles** — the command self-polls every 10s. Typically ~10–30s (the Relay route into HL is near-instant), with a 10-minute cap for slower routes. Agents should treat these as long-running: wait for the command to return rather than killing it early; a couple of poll cycles while LiFi indexes the source tx is normal.

Expand Down