Build term-info References from the full has_reference set (deduped, full URLs)#55
Merged
Merged
Conversation
…yn), deduped with full URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Build the term-info References list from the complete
has_referenceset rather than onlypubs.has_referenceedges are partitioned bytypintopubs/def_pubs/pub_syn; their union is the term's full reference list. For anatomy classespubsis empty, so References were previously reconstructed downstream from synonym/definition markdown — losing the structured DOI/PMID/FlyBase links.This adds a consolidation step in the term-info serialiser that:
pubs∪def_pubs∪pub_syn[].pub(+pub_syn[].pubs);short_form(drops duplicate edges and theUnattributedplaceholder);flybase.org/reports/<FBrf>,…/pubmed/?term=<PMID>,https://doi.org/<DOI>.Inline definition microrefs and the synonym
publicationstrings are unchanged — only the References row draws from this list.Verified
Run against the live SOLR blob:
FBbt_00003748→ 9 distinct references, full URLs, noUnattributed, no dupes.FBbt_00100243→ 10 distinct, now including the def-only Truman/Otto/Sayin pubs that previously could not be linked.FBrf0224194→ unchanged (single pub via existing path).Follow-up
VFBProcessTermInfoVFBqueryJsoncan then render icons straight fromPublications(reverts the icon-removal in uk.ac.vfb.geppetto 9f102da).