Skip to content

Build term-info References from the full has_reference set (deduped, full URLs)#55

Merged
Robbie1977 merged 1 commit into
mainfrom
feature/references-from-has-reference
Jun 27, 2026
Merged

Build term-info References from the full has_reference set (deduped, full URLs)#55
Robbie1977 merged 1 commit into
mainfrom
feature/references-from-has-reference

Conversation

@Robbie1977

Copy link
Copy Markdown
Contributor

What

Build the term-info References list from the complete has_reference set rather than only pubs.

has_reference edges are partitioned by typ into pubs / def_pubs / pub_syn; their union is the term's full reference list. For anatomy classes pubs is empty, so References were previously reconstructed downstream from synonym/definition markdown — losing the structured DOI/PMID/FlyBase links.

This adds a consolidation step in the term-info serialiser that:

  • unions pubsdef_pubspub_syn[].pub (+ pub_syn[].pubs);
  • de-duplicates by short_form (drops duplicate edges and the Unattributed placeholder);
  • emits full external URLs built from the pub-node fields — flybase.org/reports/<FBrf>, …/pubmed/?term=<PMID>, https://doi.org/<DOI>.

Inline definition microrefs and the synonym publication strings are unchanged — only the References row draws from this list.

Verified

Run against the live SOLR blob:

  • medulla FBbt_00003748 → 9 distinct references, full URLs, no Unattributed, no dupes.
  • PPL101 FBbt_00100243 → 10 distinct, now including the def-only Truman/Otto/Sayin pubs that previously could not be linked.
  • pub term FBrf0224194 → unchanged (single pub via existing path).

Follow-up

  • VFBquery point release + term-info cache refresh.
  • Java VFBProcessTermInfoVFBqueryJson can then render icons straight from Publications (reverts the icon-removal in uk.ac.vfb.geppetto 9f102da).

@Robbie1977 Robbie1977 merged commit 60949cc into main Jun 27, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant