Bound term-info sub-query counts; never re-run unbounded to count#59
Merged
Conversation
Generic high-level terms (e.g. FBbt_00000006 'head segment') hung
get_term_info: a saturated preview triggered an unbounded limit=-1
re-run of the sub-query purely to count rows, materialising every row
with full markdown/thumbnail encoding. The cold call never returned, so
the v3-cached proxy never populated and every hit re-triggered it.
- fill_query_results: replace the limit=-1 count re-run with a
COUNT_CAP-bounded re-run (env VFBQUERY_COUNT_CAP, default 1000); exact
total under the cap, otherwise -1 ("many").
- get_instances: add a count(*) aggregation over the same MATCH/OPTIONAL
grain so the true total comes back with the preview LIMIT applied,
skipping the re-run entirely.
- Wrap every sub-query call in a wall-clock budget (env
VFBQUERY_SUBQUERY_TIMEOUT_S, default 600); on overrun emit an empty
preview and count -1 so term-info as a whole always resolves and caches.
- Use count -1 (unknown) not 0 for timed-out/failed sub-queries so the
panel keeps them live and distinguishable from known-empty results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic high-level terms (e.g. FBbt_00000006 'head segment') hung get_term_info: a saturated preview triggered an unbounded limit=-1 re-run of the sub-query purely to count rows, materialising every row with full markdown/thumbnail encoding. The cold call never returned, so the v3-cached proxy never populated and every hit re-triggered it.