feat!: load monaco-editor 0.56.0 by default#67
Merged
Conversation
Upgrade `@willbooster/monaco-loader` to 2.0.0 and `monaco-editor` to 0.56.0. Monaco 0.56.0 reorganized its ESM entry points and its `exports` map no longer resolves `monaco-editor/esm/vs/editor/editor.api.js`, so the type imports now use the `monaco-editor` root entry, which re-exports the same `editor`, `Uri`, and `IDisposable` types. BREAKING CHANGE: The default asset base URL and the pinned `monaco-editor` dependency moved from 0.55.1 to 0.56.0, so consumers now load a Monaco runtime with breaking API changes (most notably `IOverlayWidgetPosition.stackOridinal` renamed to `stackOrdinal`). Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
`monaco-editor` 0.56.0 exposes its type declarations only through its `exports` map, and its legacy `typings` field points at a file missing from the published tarball, so `moduleResolution: node10` can no longer resolve them through this package's `dist/index.d.ts`. Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates monaco-editor to version 0.56.0 and @willbooster/monaco-loader to version 2.0.0. It simplifies type imports from monaco-editor/esm/vs/editor/editor.api.js to monaco-editor across the codebase, updates the README to document the new moduleResolution requirements, and updates lockfiles, tests, and snapshots accordingly. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
@willbooster/monaco-loaderto 2.0.0 andmonaco-editorto the latest stable 0.56.0.Monaco 0.56.0 reorganized its ESM entry points, and its
exportsmap no longer resolvesmonaco-editor/esm/vs/editor/editor.api.js, so the type imports now use themonaco-editorroot entry, which re-exports the sameeditor,Uri, andIDisposabletypes.Verification
bun verify-fullpasses: typecheck, unit tests, and all five Playwright e2e tests, which load the real 0.56.0 assets from jsDelivr.BREAKING CHANGE: The default asset base URL and the pinned
monaco-editordependency moved from 0.55.1 to 0.56.0, so consumers now load a Monaco runtime with breaking API changes (most notablyIOverlayWidgetPosition.stackOridinalrenamed tostackOrdinal). TypeScript consumers also need amoduleResolutionofbundler,node16, ornodenext, becausemonaco-editor0.56.0 exposes its types only through itsexportsmap.