feat(wbfy): strip retired push-back leftovers from test callers#1114
Merged
Conversation
The nightly self-applying wbfy caller pushed a `wbfy` branch and the reusable test workflow posted an aggregate commit status for push-back dispatch runs; both flows are retired. Drop the `wbfy` push branch from the test/test-rust templates, and strip the merged-in `wbfy` branch entry and the stale `statuses: write` grant from existing callers so regeneration no longer preserves them forever. Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the retired wbfy push branch and statuses: write permissions from generated workflows, ensuring older configurations are cleaned up during regeneration. A corresponding unit test has been added to verify this behavior. No review comments were provided, so there is no feedback to address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer Summary
wbfypush-branch trigger and thestatuses: writepermission disappear from test workflow callers.Technical Summary
wbfyfrom theon.push.branchesof the test / test-rust caller templates inpackages/wbfy/src/generators/workflow.ts, and filter the merged-inwbfyentry out of existing callers (alongside the existingrenovate/**filter).permissions.statusesfrom test / test-rust callers; the existing empty-permissions cleanup inwriteYamldrops the object when it empties.branches: [main, wbfy]andstatuses: writeregenerates without them.Why
wbfy(hence the push trigger), and the reusable test workflow posted an aggregate commit status for autofix push-back dispatch runs (hencestatuses: write). Both flows are retired (reusable-workflows#484/fix(deps): update all non-major dependencies #485, shared#1110/feat(wbfy)!: stop generating autofix.ci workflows and delete existing ones #1112), but wbfy's array-combining merge preserved these leftovers from older callers forever, so the fleet-wide wbfy run would never converge callers to the post-retirement shape.Testing
bun run vitest run test/unitinpackages/wbfy(30 files / 307 tests passed, including the new case).bun verifyat the repository root.