Skip to content

feat(wbfy): strip retired push-back leftovers from test callers#1114

Merged
exKAZUu merged 1 commit into
mainfrom
remove-retired-flow-leftovers-from-test-callers
Jul 26, 2026
Merged

feat(wbfy): strip retired push-back leftovers from test callers#1114
exKAZUu merged 1 commit into
mainfrom
remove-retired-flow-leftovers-from-test-callers

Conversation

@exKAZUu

@exKAZUu exKAZUu commented Jul 26, 2026

Copy link
Copy Markdown
Member

Customer Summary

  • Repositories regenerated by wbfy no longer keep CI wiring that only served the retired automated-fix flows: the wbfy push-branch trigger and the statuses: write permission disappear from test workflow callers.
  • No behavior change for day-to-day development; pull-request test runs are unaffected.

Technical Summary

  • Removed wbfy from the on.push.branches of the test / test-rust caller templates in packages/wbfy/src/generators/workflow.ts, and filter the merged-in wbfy entry out of existing callers (alongside the existing renovate/** filter).
  • Delete a merged-in permissions.statuses from test / test-rust callers; the existing empty-permissions cleanup in writeYaml drops the object when it empties.
  • Added a unit test pinning that an existing caller with branches: [main, wbfy] and statuses: write regenerates without them.

Why

Testing

  • bun run vitest run test/unit in packages/wbfy (30 files / 307 tests passed, including the new case).
  • bun verify at the repository root.

The nightly self-applying wbfy caller pushed a `wbfy` branch and the
reusable test workflow posted an aggregate commit status for push-back
dispatch runs; both flows are retired. Drop the `wbfy` push branch from
the test/test-rust templates, and strip the merged-in `wbfy` branch
entry and the stale `statuses: write` grant from existing callers so
regeneration no longer preserves them forever.

Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the retired wbfy push branch and statuses: write permissions from generated workflows, ensuring older configurations are cleaned up during regeneration. A corresponding unit test has been added to verify this behavior. No review comments were provided, so there is no feedback to address.

@exKAZUu exKAZUu self-assigned this Jul 26, 2026
@exKAZUu
exKAZUu merged commit b1e7965 into main Jul 26, 2026
6 checks passed
@exKAZUu
exKAZUu deleted the remove-retired-flow-leftovers-from-test-callers branch July 26, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant