Harden CI and close tooling gaps from code review#215
Merged
Conversation
CI / tooling:
- Stop auto-merging major-version Dependabot updates (patch/minor only)
- Replace `git add .` in pre-commit with `git update-index --again` so
formatter fixes are re-staged without sweeping in unrelated changes
- Anchor the branch-name regex, add the `ci/` prefix, fix the garbled
help text, and fix the latent branchName/currentBranch mismatch
Backend type checking:
- Fix the escaped-quote find pattern in lint.sh that matched zero files,
making mypy a silent no-op; it now checks all 15 source files
- Add mypy to requirements and a mypy.ini scoping ignore_missing_imports
to untyped libs (jose, asyncpg)
- Add a mypy type-check step to the backend CI job
- Fix the type errors mypy surfaced once it actually ran:
- resolvers: stop reusing the deleted `error` binding in the fallback
except blocks (also removes double-prefixed log messages)
- data.py: correct fetch_room return annotation (Dict, not Room)
- graphql.py: decode Response body via bytes() and drop the rebinding
- about.py: annotate `data` as Dict[str, Any] for the error path
Frontend eslint 9 migration:
- Port the legacy .eslintrc to a flat eslint.config.mjs (js recommended,
react jsx-runtime, eslint-comments rules, browser globals, custom rules)
- Remove obsolete .eslintrc and .eslintignore, resolving the
"Could not find config file" error from vite-plugin-eslint under eslint 9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI / tooling:
git add .in pre-commit withgit update-index --againso formatter fixes are re-staged without sweeping in unrelated changesci/prefix, fix the garbled help text, and fix the latent branchName/currentBranch mismatchBackend type checking:
errorbinding in the fallback except blocks (also removes double-prefixed log messages)dataas Dict[str, Any] for the error pathFrontend eslint 9 migration: