Skip to content

Harden CI and close tooling gaps from code review#215

Merged
WillSams merged 1 commit into
mainfrom
fix/harden-ci-and-fix-gaps
Jul 12, 2026
Merged

Harden CI and close tooling gaps from code review#215
WillSams merged 1 commit into
mainfrom
fix/harden-ci-and-fix-gaps

Conversation

@WillSams

Copy link
Copy Markdown
Owner

CI / tooling:

  • Stop auto-merging major-version Dependabot updates (patch/minor only)
  • Replace git add . in pre-commit with git update-index --again so formatter fixes are re-staged without sweeping in unrelated changes
  • Anchor the branch-name regex, add the ci/ prefix, fix the garbled help text, and fix the latent branchName/currentBranch mismatch

Backend type checking:

  • Fix the escaped-quote find pattern in lint.sh that matched zero files, making mypy a silent no-op; it now checks all 15 source files
  • Add mypy to requirements and a mypy.ini scoping ignore_missing_imports to untyped libs (jose, asyncpg)
  • Add a mypy type-check step to the backend CI job
  • Fix the type errors mypy surfaced once it actually ran:
    • resolvers: stop reusing the deleted error binding in the fallback except blocks (also removes double-prefixed log messages)
    • data.py: correct fetch_room return annotation (Dict, not Room)
    • graphql.py: decode Response body via bytes() and drop the rebinding
    • about.py: annotate data as Dict[str, Any] for the error path

Frontend eslint 9 migration:

  • Port the legacy .eslintrc to a flat eslint.config.mjs (js recommended, react jsx-runtime, eslint-comments rules, browser globals, custom rules)
  • Remove obsolete .eslintrc and .eslintignore, resolving the "Could not find config file" error from vite-plugin-eslint under eslint 9

CI / tooling:
- Stop auto-merging major-version Dependabot updates (patch/minor only)
- Replace `git add .` in pre-commit with `git update-index --again` so
  formatter fixes are re-staged without sweeping in unrelated changes
- Anchor the branch-name regex, add the `ci/` prefix, fix the garbled
  help text, and fix the latent branchName/currentBranch mismatch

Backend type checking:
- Fix the escaped-quote find pattern in lint.sh that matched zero files,
  making mypy a silent no-op; it now checks all 15 source files
- Add mypy to requirements and a mypy.ini scoping ignore_missing_imports
  to untyped libs (jose, asyncpg)
- Add a mypy type-check step to the backend CI job
- Fix the type errors mypy surfaced once it actually ran:
  - resolvers: stop reusing the deleted `error` binding in the fallback
    except blocks (also removes double-prefixed log messages)
  - data.py: correct fetch_room return annotation (Dict, not Room)
  - graphql.py: decode Response body via bytes() and drop the rebinding
  - about.py: annotate `data` as Dict[str, Any] for the error path

Frontend eslint 9 migration:
- Port the legacy .eslintrc to a flat eslint.config.mjs (js recommended,
  react jsx-runtime, eslint-comments rules, browser globals, custom rules)
- Remove obsolete .eslintrc and .eslintignore, resolving the
  "Could not find config file" error from vite-plugin-eslint under eslint 9
@WillSams WillSams merged commit 27ef5ba into main Jul 12, 2026
4 checks passed
@WillSams WillSams deleted the fix/harden-ci-and-fix-gaps branch July 12, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant