Enhancement: Use distinct visual styles for different issue types #1384#1388
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
davidperezgar
left a comment
There was a problem hiding this comment.
Change colors less aggresive.
|
Hello @davidperezgar |
|
hello @davidperezgar I just changed the colors, let me know if it works.
|
|
Ok, nice! thanks |
|
@ernilambar sure, I will change the class and let you know. |
|
@ernilambar Just updated. please check and let me know. |


What?
Closes #1384
Using badges instead of raw ERROR/WARNING text to improve the user experience.
Why?
As a Plugin Check user, I always use it before pushing any version of my plugin. I noticed that it's hard to visually distinguish errors and warnings. Even though I can turn warnings/errors off, using badges makes it easier for our brains to quickly identify whether something is an error or a warning, making it slightly more effective. I noticed someone had already created an issue, and I thought I would try to implement it myself since it's not a huge change.
How?
As a fix, I added custom classes
plugin-check__results-row-typeandplugin-check__results-row-type--{{error_type}}, and wrapped the ERROR/WARNING text inside a<span>. I also added custom CSS to theassets/css/plugin-check-admin.cssfile with a proper comment. I used#dc3545as the ERROR badge background color and#ffc107as the WARNING badge background color.Testing Instructions
AI Usage Disclosure
It's a tiny change. I did it myself, but I used AI to fix typos and grammatical mistakes in the PR message.
Screenshots
Co-authored-by: kmfoysal06 kmfoysal06@git.wordpress.org
Co-authored-by: tushar-addweb tusharaddweb@git.wordpress.org