Skip to content

Build/Test Tools: Treat request-scoped constants as dynamic in PHPStan #13071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tstokes8040 wants to merge 1 commit into
base: trunk
Choose a base branch
from
+8 −21
Open

Build/Test Tools: Treat request-scoped constants as dynamic in PHPStan #13071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/phpstan/base.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ parameters:
- DB_COLLATE
- DISALLOW_FILE_EDIT
- DISALLOW_UNFILTERED_HTML
- DOING_AJAX
- DOING_CRON
- EMPTY_TRASH_DAYS
- ENFORCE_GZIP
- FORCE_SSL_LOGIN
Expand All @@ -93,6 +95,7 @@ parameters:
- MULTISITE
- NO_HEADER_TEXT
- NOBLOGREDIRECT
- REST_REQUEST
- SAVEQUERIES
- SCRIPT_DEBUG
- SECRET_KEY
Expand All @@ -106,16 +109,20 @@ parameters:
- WP_DEBUG_DISPLAY
- WP_DEBUG_LOG
- WP_DEVELOPMENT_MODE
- WP_INSTALLING
- WP_INSTALLING_NETWORK
- WP_LANG_DIR
- WP_NETWORK_ADMIN
- WP_POST_REVISIONS
- WP_REPAIRING
- WP_SITEURL
- WP_USE_THEMES
- WP_USER_ADMIN
- WPLANG
- WPMU_ACCEL_REDIRECT
- WPMU_PLUGIN_DIR
- WPMU_SENDFILE
- XMLRPC_REQUEST

# What directories and files should be scanned.
paths:
Expand Down
22 changes: 1 addition & 21 deletions tests/phpstan/baselines/booleanAnd.rightAlwaysTrue.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ parameters:
identifier: booleanAnd.rightAlwaysTrue
count: 1
path: ../../../src/wp-admin/includes/class-wp-site-health.php
-
message: '#^Right side of && is always true\.$#'
identifier: booleanAnd.rightAlwaysTrue
count: 1
path: ../../../src/wp-admin/includes/schema.php
-
message: '#^Right side of && is always true\.$#'
identifier: booleanAnd.rightAlwaysTrue
Expand All @@ -46,20 +41,5 @@ parameters:
-
message: '#^Right side of && is always true\.$#'
identifier: booleanAnd.rightAlwaysTrue
count: 2
count: 1
path: ../../../src/wp-includes/functions.php
-
message: '#^Right side of && is always true\.$#'
identifier: booleanAnd.rightAlwaysTrue
count: 3
path: ../../../src/wp-includes/l10n.php
-
message: '#^Right side of && is always true\.$#'
identifier: booleanAnd.rightAlwaysTrue
count: 4
path: ../../../src/wp-includes/load.php
-
message: '#^Right side of && is always true\.$#'
identifier: booleanAnd.rightAlwaysTrue
count: 2
path: ../../../src/wp-includes/user.php