Removes ignored errors from staticClassAccess.privateMethod.neon baseline file - #13072
Removes ignored errors from staticClassAccess.privateMethod.neon baseline file#13072dpanta94 wants to merge 5 commits into
staticClassAccess.privateMethod.neon baseline file#13072Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1d08043 to
0dee829
Compare
0dee829 to
52f486d
Compare
staticClassAccess.privateMethod.neon baseline file
Removes in total
20errors.Removes errors from the below phpstan baselines and fixes the issues that they were covering:
How ?
Replaces usage of
static::withself::in classes which were using self while trying to access API meant to be private.This is safe to merge. Even if the static usage was aimed to be used for overwrite via inheritance, if a Child class would try to overwrite the private static methods a fatal error would be thrown.
Trac ticket: https://core.trac.wordpress.org/ticket/65817
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 5
Used for: Help with suggesting how to fix the phpstan output for the specific errors we are removing the baselines for. The actual result has been reviewed and are owned by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.