Skip to content

Removes baseline for catch.neverThrown and issue from identical.alwaysFalse.neon - #13073

Open
dpanta94 wants to merge 6 commits into
WordPress:trunkfrom
dpanta94:fix/phpstan-baselines.3
Open

Removes baseline for catch.neverThrown and issue from identical.alwaysFalse.neon#13073
dpanta94 wants to merge 6 commits into
WordPress:trunkfrom
dpanta94:fix/phpstan-baselines.3

Conversation

@dpanta94

@dpanta94 dpanta94 commented Aug 16, 2026

Copy link
Copy Markdown

Removes in total 4 errors.

Removes errors from the below phpstan baselines and fixes the issues that they were covering:

  • catch.neverThrown.neon
  • identical.alwaysFalse.neon

How ?

  • In the file src/wp-includes/html-api/class-wp-html-processor.php

Adds a doc-level @throws for the Exception specifically which may very well happen in all these methods since all these methods may call the method bookmark_token .

and makes the class read the last_error property through the method get_last_error which is also marked as impure to indicate that class state can change its return value.

  • Removes dead code from src/wp-admin/plugins.php - see line 174 of the same file.

  • In the file src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php, removes boolean false check which is already covered by the empty check.

Trac ticket: https://core.trac.wordpress.org/ticket/65817

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 5
Used for: Help with suggesting how to fix the phpstan output for the specific errors we are removing the baselines for. The actual result has been reviewed and are owned by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props dpantazis.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@dpanta94
dpanta94 force-pushed the fix/phpstan-baselines.3 branch from 8ec6eda to 470f606 Compare August 16, 2026 20:11
@dpanta94
dpanta94 force-pushed the fix/phpstan-baselines.3 branch from 470f606 to ef0d247 Compare August 16, 2026 20:25
@dpanta94 dpanta94 changed the title fix: removes baseline for catch.neverThrown Removes baseline for catch.neverThrown and issue from identical.alwaysFalse.neon Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant