Removes baseline for catch.neverThrown and issue from identical.alwaysFalse.neon - #13073
Removes baseline for catch.neverThrown and issue from identical.alwaysFalse.neon#13073dpanta94 wants to merge 6 commits into
catch.neverThrown and issue from identical.alwaysFalse.neon#13073Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
8ec6eda to
470f606
Compare
470f606 to
ef0d247
Compare
catch.neverThrown and issue from identical.alwaysFalse.neon
Removes in total
4errors.Removes errors from the below phpstan baselines and fixes the issues that they were covering:
How ?
Adds a doc-level
@throwsfor theExceptionspecifically which may very well happen in all these methods since all these methods may call the methodbookmark_token.and makes the class read the
last_errorproperty through the methodget_last_errorwhich is also marked as impure to indicate that class state can change its return value.Removes dead code from src/wp-admin/plugins.php - see line 174 of the same file.
In the file src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php, removes boolean false check which is already covered by the empty check.
Trac ticket: https://core.trac.wordpress.org/ticket/65817
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 5
Used for: Help with suggesting how to fix the phpstan output for the specific errors we are removing the baselines for. The actual result has been reviewed and are owned by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.