Remove return.missing baseline and fix its issue - #13082
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
left a comment
There was a problem hiding this comment.
With a number of mixed categories of missing returns, this PR is probably too big to merge as a single change. Could we split it into those which should be benign by simply adding a missing return null; as the last statement in a function, from those which involve Docblock changes, from those which rearrange the return code (e.g. general-template.php, with the $display check).
those last ones seem trivial, but I fear from experience that it’s easy to accidentally flip a boolean and then introduce a regression
Removes in total
41errors.Removes errors from the below phpstan baselines and fixes the issues that they were covering:
How ?
Adds return types according to method docblocks.
Trac ticket: https://core.trac.wordpress.org/ticket/65817
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Opus 5
Used for: Help with suggesting how to fix the phpstan output for the specific errors we are removing the baselines for. The actual result has been reviewed and are owned by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.