Skip to content

Code Quality: Remove three redundant boolean sub-expressions #13086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tstokes8040 wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Code Quality: Remove three redundant boolean sub-expressions #13086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a36a72b
Code Quality: Remove three redundant boolean sub-expressions.
tstokes8040 Aug 16, 2026
d684f33
Merge branch 'trunk' into phpstan/redundant-subexpressions
tstokes8040 Aug 16, 2026
2a4090f
Merge branch 'trunk' into phpstan/redundant-subexpressions
tstokes8040 Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wp-includes/block-supports/typography.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ function wp_typography_get_preset_inline_style_value( $style_value, $css_propert
* @return string Filtered block content.
*/
function wp_render_typography_support( $block_content, $block ) {
if ( ! empty( $block['attrs']['fitText'] ) && $block['attrs']['fitText'] && ! is_admin() ) {
if ( ! empty( $block['attrs']['fitText'] ) && ! is_admin() ) {
wp_enqueue_script_module( '@wordpress/block-editor/utils/fit-text-frontend' );

// Add Interactivity API directives for fit text to work with client-side navigation.
Expand Down
2 changes: 1 addition & 1 deletion src/wp-includes/block-template-utils.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ function _get_block_templates_files( $template_type, $query = array() ) {

if (
! $post_type ||
( $post_type && isset( $candidate['postTypes'] ) && in_array( $post_type, $candidate['postTypes'], true ) )
( isset( $candidate['postTypes'] ) && in_array( $post_type, $candidate['postTypes'], true ) )
) {
$template_files[ $template_slug ] = $candidate;
}
Expand Down
2 changes: 1 addition & 1 deletion src/wp-includes/class-wp-walker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public function display_element( $element, &$children_elements, $max_depth, $dep
unset( $children_elements[ $id ] );
}

if ( isset( $newlevel ) && $newlevel ) {
if ( isset( $newlevel ) ) {
// End the child delimiter.
$this->end_lvl( $output, $depth, ...array_values( $args ) );
}
Expand Down
5 changes: 0 additions & 5 deletions tests/phpstan/baselines/booleanAnd.leftAlwaysTrue.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ parameters:
identifier: booleanAnd.leftAlwaysTrue
count: 1
path: ../../../src/wp-admin/themes.php
-
message: '#^Left side of && is always true\.$#'
identifier: booleanAnd.leftAlwaysTrue
count: 1
path: ../../../src/wp-includes/block-template-utils.php
-
message: '#^Left side of && is always true\.$#'
identifier: booleanAnd.leftAlwaysTrue
Expand Down
10 changes: 0 additions & 10 deletions tests/phpstan/baselines/booleanAnd.rightAlwaysTrue.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,6 @@ parameters:
identifier: booleanAnd.rightAlwaysTrue
count: 1
path: ../../../src/wp-content/themes/twentynineteen/header.php
-
message: '#^Right side of && is always true\.$#'
identifier: booleanAnd.rightAlwaysTrue
count: 1
path: ../../../src/wp-includes/block-supports/typography.php
-
message: '#^Right side of && is always true\.$#'
identifier: booleanAnd.rightAlwaysTrue
count: 1
path: ../../../src/wp-includes/class-wp-walker.php
-
message: '#^Right side of && is always true\.$#'
identifier: booleanAnd.rightAlwaysTrue
Expand Down
Loading