Build/Test Tools: Remove the unused wp_mail real-send script - #13094
Build/Test Tools: Remove the unused wp_mail real-send script#13094lancewillett wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Trac ticket: https://core.trac.wordpress.org/ticket/65894
What this changes
Removes the unused
tests/phpunit/wp-mail-real-test.phpfile.The script is not a PHPUnit test and is never collected by a test run. It has no callers, and three of its
requirepaths point at files that do not exist, so it fatals on any invocation.Its scenario is already covered with assertions by
test_wp_mail_rfc2822_addresses()intests/phpunit/tests/pluggable/wpMail.php, which exercises the same To/From/CC/BCC headers throughMockPHPMailer.Removing it prevents future standards sweeps and review time from landing on a script that cannot run. If a real-delivery smoke test is wanted later, it can be built against the current bootstrap.
Testing
git diff --checkpassed.wp-mail-real-testremain anywhere in the repository.defaulttestsuite inphpunit.xml.distglobs onlytests/phpunit/tests, so the file was never collected.tests/phpunit/wp-testlib/andtests/phpunit/wp-config.php, which the script requires, do not exist.wp_mail()suite on this branch:phpunit --filter 'Tests_Pluggable_wpMail'givesOK (32 tests, 87 assertions), so the RFC2822 address handling the script exercised is still covered.No runtime tests were added because this removes an unreachable script.