Skip to content

Build/Test Tools: Remove the unused wp_mail real-send script - #13094

Open
lancewillett wants to merge 1 commit into
WordPress:trunkfrom
lancewillett:chore/65894-remove-unused-wp-mail-real-test
Open

Build/Test Tools: Remove the unused wp_mail real-send script#13094
lancewillett wants to merge 1 commit into
WordPress:trunkfrom
lancewillett:chore/65894-remove-unused-wp-mail-real-test

Conversation

@lancewillett

Copy link
Copy Markdown
Member

Trac ticket: https://core.trac.wordpress.org/ticket/65894

What this changes

Removes the unused tests/phpunit/wp-mail-real-test.php file.

The script is not a PHPUnit test and is never collected by a test run. It has no callers, and three of its require paths point at files that do not exist, so it fatals on any invocation.

Its scenario is already covered with assertions by test_wp_mail_rfc2822_addresses() in tests/phpunit/tests/pluggable/wpMail.php, which exercises the same To/From/CC/BCC headers through MockPHPMailer.

Removing it prevents future standards sweeps and review time from landing on a script that cannot run. If a real-delivery smoke test is wanted later, it can be built against the current bootstrap.

Testing

  • git diff --check passed.
  • Confirmed no references to wp-mail-real-test remain anywhere in the repository.
  • Confirmed the default testsuite in phpunit.xml.dist globs only tests/phpunit/tests, so the file was never collected.
  • Confirmed tests/phpunit/wp-testlib/ and tests/phpunit/wp-config.php, which the script requires, do not exist.
  • Ran the wp_mail() suite on this branch: phpunit --filter 'Tests_Pluggable_wpMail' gives OK (32 tests, 87 assertions), so the RFC2822 address handling the script exercised is still covered.

No runtime tests were added because this removes an unreachable script.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant