fix(p2p): skip UDP discovery whenever nodiscover is enabled - #2478
Open
gzliudan wants to merge 1 commit into
Open
fix(p2p): skip UDP discovery whenever nodiscover is enabled#2478gzliudan wants to merge 1 commit into
gzliudan wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gzliudan
requested review from
AnilChinchawale,
anunay-xin,
benjamin202410,
liam-lai and
wanwiset25
July 20, 2026 23:56
gzliudan
force-pushed
the
fix-test-bind-err
branch
2 times, most recently
from
July 23, 2026 06:35
a3e5c08 to
87c40b3
Compare
Align discovery startup behavior with geth by making setupDiscovery return early when NoDiscovery is enabled. This prevents intermittent UDP bind conflicts in nodiscover startup tests.
gzliudan
force-pushed
the
fix-test-bind-err
branch
from
July 23, 2026 10:00
87c40b3 to
22b39b3
Compare
anunay-xin
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR aligns discovery startup behavior with geth by making startup return early when nodiscover is enabled.
Motivation
Quick-test intermittently failed with address already in use caused by UDP discovery socket binding during nodiscover startup paths.
Impact
Nodes started with nodiscover no longer bind UDP discovery sockets, which removes intermittent port-collision failures and keeps behavior consistent with expected nodiscover semantics.
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that