Longest Palindromic Substring - #105
Open
Yuto729 wants to merge 1 commit into
Open
Conversation
|
お疲れ様です。 Longest Palindromic Substringに取り組みました。 問題: https://leetcode.com/problems/longest-palindromic-substring |
nodchip
reviewed
Aug 11, 2026
| dp2 = dp1 | ||
| dp1 = dp | ||
|
|
||
| return s[longest_start: longest_end + 1] |
There was a problem hiding this comment.
スライスの : の両側には、同じ数のスペースを空けることをお勧めいたします。
参考までにスタイルガイドへのリンクを共有いたします。
https://peps.python.org/pep-0008/#whitespace-in-expressions-and-statements
# Wrong:
ham[1: 9], ham[1 :9], ham[1:9 :3]
なお、このスタイルガイドは“唯一の正解”というわけではなく、数あるガイドラインの一つに過ぎません。チームによって重視される書き方や慣習も異なります。そのため、ご自身の中に基準を持ちつつも、最終的にはチームの一般的な書き方に合わせることをお勧めします。
| # dp[i][j] = s[i: j + 1]がPalindromeかどうか, boolen | ||
| longest_start = 0 | ||
| longest_end = 0 | ||
| dp = [[False] * n for _ in range(n)] |
There was a problem hiding this comment.
dp という変数名は Dynamic Programming の略だと思うのですが、読み手にとってあまり有益な情報が含まれていないように思います。中に格納される値を表す英単語や英語句を付けると良いと思います。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解く問題
Longest Palindromic Substring
次に解く問題