feat(e13): plan smart add onboarding + S1 local blobparse redaction library - #60
Merged
Conversation
Add ADR-0003 (env/file/paste add inputs; opt-in secret-free --ai parse that narrowly amends ADR-0001 D8 for that path only), the E13 epic entry, and 5 story specs (E13-S1..S5). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lands the E13 — Smart `add` Onboarding plan and its first substrate story.
Planning (docs):
docs/decisions/0003-smart-add-scope.md— ADR-0003. Adds env/file/paste input sources toadd. The only network path is an opt-in, secret-free--aiparse; it narrowly amends ADR-0001 Decision 8 for that path only. Every other E13 path is zero-network.docs/plan/epics.md— E13 epic entry (5 stories).docs/plan/stories/E13-S1..S5.md— story specs.Code (E13-S1):
internal/blobparse— pure, local, deterministic extractor. Given arbitrary pasted text it returns the extracted core fields plus a desensitized copy in which no secret-shaped token survives ("strip on doubt"). Substrate for E13-S4 (--from-text) and E13-S5 (--ai).Review trail
Fresh-context adversarial review flagged a Critical gap: bare unlabeled secrets (Google
AIza…, 40-hex, base64 blobs) survived desensitization, and the property test reused production patterns as its own oracle (self-certifying). Remediated in210ad03:Independently verified with an oracle not derived from production regexes:
AIza…, 40-hex, base64 blob, bare/(wrapped)sk-all redact to placeholders whilebase_url=https://…is preserved.Scope / safety
cmd/wiring yet (S4 does that).--ai) is not exercised here and remains flagged for final sign-off.🤖 Generated with Claude Code