ci: restore required permissions for the Features reusable workflow#679
ci: restore required permissions for the Features reusable workflow#679emptyhammond wants to merge 1 commit into
Conversation
The build job in features.yml calls the reusable workflow ably/features/.github/workflows/sdk-features.yml@main, whose job requires deployments: write and id-token: write. After #678 scoped the caller job to only contents: read, those scopes were stripped (a reusable workflow cannot elevate beyond what the caller grants), causing an invisible failure at workflow startup. Grant the two missing scopes on the calling job so OIDC (aws-actions/configure-aws-credentials) and the sdk-upload-action work again. Top-level permissions: {} is left intact. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 58 minutes and 25 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Context
PR #678 (GitHub Actions workflow security cleanup) added a top-level
permissions: {}tofeatures.ymland granted thebuildjob onlycontents: read.That
buildjob calls the reusable workflowably/features/.github/workflows/sdk-features.yml@main, whose job declares it needs:For reusable workflows, the caller's job permissions cap what the called workflow receives — a called workflow cannot elevate beyond what the caller grants. With the caller capped at
contents: read, the reusable workflow lostid-token: write(used byaws-actions/configure-aws-credentialsfor OIDC) anddeployments: write(used byably/sdk-upload-action), producing an invisible failure at workflow startup. The Features workflow is currently broken onmain.Flagged by @VeskeR on ably/ably-dotnet#1328 and observed failing on ably-python run 26639799574, as well as ably-js and ably-dotnet.
Change
Grant the two missing scopes on the calling job. Top-level
permissions: {}is left intact.Follow-up
The same one-line fix is needed in sibling SDK repos (ably-js, ably-dotnet, possibly others). Out of scope for this PR.
🤖 Generated with Claude Code