test(buy-flow): assert in-flight pending indicator and post-confirm clear (#672) - #729
Merged
Chucks1093 merged 1 commit intoJul 29, 2026
Conversation
|
@dedukpe Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
displays a pending indicator during the buy and clears it after confirmation (#672)) tosrc/pages/__tests__/LandingPage.buyFlowEndToEnd.integration.test.tsx.disabled,aria-busy="true", theStableButtonContentflips to the loading slot (Submitting…visible,Confirm buyhidden via the Tailwindinvisibleclass +aria-hidden), the loading toast fires, and the optimistic-updatePendingpill appears on the holdings row.Pendingpill disappears onceuseMutation.onSuccessflips cachedpendingback tofalse.showToast.transactionSuccessis asserted with the same args as the existing Add integration test for the buy flow completing end-to-end from quantity input to success toast #642 buy-flow E2E test ('Trade confirmed'/'Holdings refreshed: +N keys.').<TradeDialog open isSubmitting={false} />; the reopened confirm button is not disabled, has noaria-busy, showsConfirm buy, andSubmitting…is hidden via the inverseStableButtonContentslot. If the parent'stradeSubmittingflag had been left true, this rerender would still surfacearia-busyand the loading label.courseService.getCourses,showToastsink, network/staleness hooks,framer-motionpass-through, presentation mocks forCreatorCard/StellarConnectionQualityBadge/FeaturedCreatorAudienceChip). No new mocks, no fixture changes.Testing
pnpm lint— passes (only this test file touched; no new lint warnings)npx tsc -b— passes (test file compiles cleanly)pnpm build— Vite bundle step is broken in this environment due to a missing@tailwindcss/oxidenative binding unrelated to this change; the TypeScript stage ofpnpm build(i.e.tsc -b) passes.pnpm test— should be verified by CI; locallyvitest listconfirms all four test cases (the three pre-existing + this new one) parse and register cleanly. Real-time execution relies on the existing 900 ms in-wallet simulation and should complete in under 5 s per test.Checklist
Refs: #672.