Add sell holder count unit tests 675 - #692
Merged
Chucks1093 merged 2 commits intoJul 29, 2026
Merged
Conversation
|
@somotochukwu-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a unit test for the sell function correctly decrementing the holder count when a wallet sells all its keys.
Changes
creator-keys/tests/sell_key.rs: Addedtest_multi_key_full_exit_decrements_holder_count_only_on_last_sell— a wallet holding 3 keys sells 2 (holder count unchanged), then sells the last key (holder count decrements to 0). This fills the gap where no existing test verified holder count only decrements on the final sale when a wallet holds more than one key.Acceptance criteria coverage
The following scenarios were already covered by existing tests and remain passing:
test_sell_key_removes_holder_when_last_key_is_soldtest_sell_key_preserves_holder_count_when_seller_still_has_keystest_holder_count_reflects_mixed_trade_correctlyinsupply_invariants.rsThe new test covers the previously untested scenario of a multi-key wallet fully exiting.
Closes #675