Skip to content

fix: use shared webhook retry delay helper - #731

Merged
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
nomsoscript:fix/webhook-retry-delay-597
Jul 30, 2026
Merged

fix: use shared webhook retry delay helper#731
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
nomsoscript:fix/webhook-retry-delay-597

Conversation

@nomsoscript

Copy link
Copy Markdown
Contributor

Closes #597

Changes

  • Replaces the webhook retry inline delay calculation with the shared computeRetryDelay helper.
  • Uses the configured webhook base retry delay and caps retry backoff at 30 seconds.
  • Pins jitter in the retry unit test for deterministic timer assertions.
  • Strengthens retry exhaustion assertions to verify the structured error log emits exactly once and does not include the callback URL.

Testing

  • git diff --check
  • pnpm exec jest src/utils/__tests__/retry-delay.utils.test.ts src/modules/webhooks/webhook.service.test.ts --runInBand attempted locally, but this machine timed out while pnpm was still materializing dependencies before Jest started.

@Chucks1093
Chucks1093 merged commit 4ac795b into accesslayerorg:main Jul 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add webhook retry delay helper with exponential backoff and structured error logging on exhaustion

2 participants