Skip to content

[Accton] Check TX_DISABLE support before access in onlp_sfpi_control_… #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eric271110 wants to merge 8 commits into
base: support_linux_6.1
Choose a base branch
from
Open

[Accton] Check TX_DISABLE support before access in onlp_sfpi_control_… #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a8947d9
[Accton] Check TX_DISABLE support before access in onlp_sfpi_control_…
eric271110 Jun 12, 2026
95acf33
[Accton] remove redundant CMIS bank setting in control_get/set
eric271110 Jun 15, 2026
2dc2a4d
[Accton]Add SFP functionality (LP mode, reset, TX disable)
eric271110 Jun 15, 2026
1756289
[Accton] Move QSFP-DD bank-select to before page 10h switch
eric271110 Jun 23, 2026
16df657
[Accton] sfpi.c: replace AIM_LOG_ERROR with syslog and remove unneces…
eric271110 Jul 3, 2026
096e616
[Accton] sfpi.c: prevent tx_disable set/get result from being overwri…
eric271110 Jul 10, 2026
c184c6f
[Accton] sfpi.c: unify tx_disable set/get log messages with as9726-32d
eric271110 Jul 20, 2026
639ef77
[Accton] sfpi.c: unify tx_disable log wording
eric271110 Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 75 additions & 48 deletions ...atforms/accton/x86-64/as7535-28xb/onlp/builds/x86_64_accton_as7535_28xb/module/src/sfpi.c
View file
Open in desktop

Large diffs are not rendered by default.

202 changes: 117 additions & 85 deletions ...forms/accton/x86-64/as7926-40xfb/onlp/builds/x86_64_accton_as7926_40xfb/module/src/sfpi.c
View file
Open in desktop

Large diffs are not rendered by default.

109 changes: 70 additions & 39 deletions ...atforms/accton/x86-64/as7946-30xb/onlp/builds/x86_64_accton_as7946_30xb/module/src/sfpi.c
View file
Open in desktop

Large diffs are not rendered by default.

109 changes: 70 additions & 39 deletions ...forms/accton/x86-64/as7946-74xkb/onlp/builds/x86_64_accton_as7946_74xkb/module/src/sfpi.c
View file
Open in desktop

Large diffs are not rendered by default.

206 changes: 119 additions & 87 deletions ...platforms/accton/x86-64/as9716_32d/onlp/builds/x86_64_accton_as9716_32d/module/src/sfpi.c
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 6 additions & 16 deletions ...platforms/accton/x86-64/as9726-32d/onlp/builds/x86_64_accton_as9726_32d/module/src/sfpi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,10 +383,6 @@ int onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
if (status_byte & QSFP_DD_FLAT_MEM) {
return ONLP_STATUS_E_UNSUPPORTED;
}
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_BANK_SELECT, 0)) < 0) {
syslog(LOG_ERR, "Failed to set Bank 0, unable to write tx_disable status to port(%d)", port);
return ONLP_STATUS_E_INTERNAL;
}
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_ADVERTISING)) < 0) {
syslog(LOG_ERR, "Failed to switch to Advertising Page on port(%d)", port);
goto restore;
Expand All @@ -398,7 +394,7 @@ int onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
}
if (support_ctrls & QSFP_DD_P01H_TX_DISABLE_SUPPORT) {
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_BANK_SELECT, 0)) < 0) {
syslog(LOG_ERR, "Failed to set Bank 0 on port(%d)", port);
syslog(LOG_ERR, "Failed to set Bank 0, unable to write tx_disable status to port(%d)", port);
goto restore;
}
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_LANE_CTRL)) < 0) {
Expand All @@ -422,7 +418,6 @@ int onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)
}

if (rv < 0) {
syslog(LOG_ERR, "Unable to write tx_disable status to port(%d)", port);
rv = (rv == ONLP_STATUS_E_UNSUPPORTED) ? rv : ONLP_STATUS_E_INTERNAL;
} else {
rv = ONLP_STATUS_OK;
Expand Down Expand Up @@ -474,7 +469,7 @@ int onlp_sfpi_control_set(int port, onlp_sfp_control_t control, int value)

if (onlp_file_write_int(value, MODULE_LPMODE_FORMAT,
bus, addr, (port + 1)) < 0) {
syslog(LOG_ERR, "Unable to set lp mode to port(%d)",
syslog(LOG_ERR, "Unable to set LP mode to port(%d)",
port);
rv = ONLP_STATUS_E_INTERNAL;
} else {
Expand Down Expand Up @@ -554,10 +549,6 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
if (status_byte & QSFP_DD_FLAT_MEM) {
return ONLP_STATUS_E_UNSUPPORTED;
}
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_BANK_SELECT, 0)) < 0) {
syslog(LOG_ERR, "Failed to set Bank 0, unable to read tx_disable status from port(%d)", port);
return ONLP_STATUS_E_INTERNAL;
}
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_ADVERTISING)) < 0) {
syslog(LOG_ERR, "Failed to switch to Advertising Page on port(%d)", port);
goto restore;
Expand All @@ -569,7 +560,7 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
}
if (support_ctrls & QSFP_DD_P01H_TX_DISABLE_SUPPORT) {
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_BANK_SELECT, 0)) < 0) {
syslog(LOG_ERR, "Failed to set Bank 0 on port(%d)", port);
syslog(LOG_ERR, "Failed to set Bank 0, unable to read tx_disable status from port(%d)", port);
goto restore;
}
if ((rv = onlp_sfpi_dev_writeb(port, PORT_EEPROM_DEVADDR, QSFP_EEPROM_OFFSET_PAGE_SELECT, QSFP_DD_PAGE_LANE_CTRL)) < 0) {
Expand All @@ -578,7 +569,7 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
goto restore;
}
if ((tx_dis = onlp_sfpi_dev_readb(port, PORT_EEPROM_DEVADDR, QSFP_DD_P10H_OFFSET_OUTPUT_DISABLE_TX)) < 0) {
syslog(LOG_ERR, "Failed to read TX_DISABLE value from Lane Control register on port(%d)", port);
syslog(LOG_ERR, "Failed to read tx_disable value from Lane Control register on port(%d)", port);
rv = tx_dis;
goto restore;
}
Expand All @@ -594,7 +585,6 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
}

if (rv < 0) {
syslog(LOG_ERR, "Unable to get tx_disable status from port(%d)", port);
rv = (rv == ONLP_STATUS_E_UNSUPPORTED) ? rv : ONLP_STATUS_E_INTERNAL;
} else {
*value = (tx_dis & 0xff);
Expand All @@ -613,7 +603,7 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)
addr = 62;
if (onlp_file_read_int(value, MODULE_TXDISABLE_FORMAT,
bus, addr, (port+1)) < 0) {
syslog(LOG_ERR, "Unable to read tx_disabled status from port(%d)",
syslog(LOG_ERR, "Unable to read tx_disable status from port(%d)",
port);
rv = ONLP_STATUS_E_INTERNAL;
} else {
Expand Down Expand Up @@ -647,7 +637,7 @@ int onlp_sfpi_control_get(int port, onlp_sfp_control_t control, int* value)

if (onlp_file_read_int(value, MODULE_LPMODE_FORMAT,
bus, addr, (port + 1)) < 0) {
syslog(LOG_ERR, "Unable to get lp mode to port(%d)",
syslog(LOG_ERR, "Unable to get LP mode to port(%d)",
port);
rv = ONLP_STATUS_E_INTERNAL;
} else {
Expand Down
Loading