refactor!: remove index from trace - #263
Open
drmorr0 wants to merge 1 commit into
Open
Conversation
drmorr0
force-pushed
the
drmorr/remove-index
branch
2 times, most recently
from
July 15, 2026 19:36
fb56610 to
811f406
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
- Coverage 79.25% 79.16% -0.09%
==========================================
Files 61 61
Lines 4010 3999 -11
==========================================
- Hits 3178 3166 -12
- Misses 832 833 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
drmorr0
force-pushed
the
drmorr/remove-index
branch
from
July 15, 2026 19:44
811f406 to
31ef5d5
Compare
drmorr0
force-pushed
the
drmorr/remove-index
branch
from
July 15, 2026 19:57
31ef5d5 to
1c765f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Rationale
ResourceMetadatastruct. The driver still needs a way to look up whether a resource is in the trace or not, and the next PR after this is going to add fields to theResourceMetadatastruct so that we can track the pod spec template hash values (see the design doc).How
Test Steps
Other Notes
Note that this is a breaking change, old trace files will no longer work with this version of simkube.
I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.