Update visible-label-in-accessible-name-2ee8b8.md by kengdoj · Pull Request #2101 · act-rules/act-rules.github.io

kengdoj · 2023-08-21T23:40:09Z

Update examples to include #1458 (comment)
Closes issue(s):

closes #XXX (ADD ISSUE NUMBER HERE)

Need for Call for Review:

This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of test cases, if in doubt, use this. >>

Pull Request Etiquette

When creating PR:

Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

Add yourself (and co-authors) as "Assignees" for PR.
Add label to indicate if it's a Rule, Definition or Chore.
Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

Jym77

How do the changes relate to #2075?

Jym77 · 2023-09-28T09:40:01Z


 ```html
-<button aria-label="close">X</button>
+<button aria-label="anything">X</button>


Shouldn't we keep the "Close" label, which makes this pass 1.1.1?
(assuming this is indeed a close button)

Because the Expectation says

except for characters in the [text nodes][] used to express [non-text content][]

there is no expectation, and this example passes. I used aria-label="anything" to make it clear that really any description would pass this rule. But, you are right that SC 1.1.1 would then be not satisfied. But I'd like to consider SC 1.1.1 being secondary and handle that in a separate PR.

This comes up often around here: when passed examples fail something else.

I like it best when there is a note on the passed example which documents that "something else". In this case that note could be: "This example passes the rule and will fail SC 1.1.1".

We could call these "curve ball passed examples".

To have examples like these, and to document them as such, meets two goals, both important:

It emphasizes why the example passes the rule. (In this case: "to make it clear that really any description would pass this rule", as Kathy put it). I think that this aids understanding, a lot.

It tells everyone that even though this is a "passed example" for this rule, it's not a good example overall, so no one should copy and paste the code.

Jean-Yves did this a lot in the examples for his recent PR 2084:

"Using an explicit role of generic for any element is globally not recommended, but not an error by itself."

"Using an explicit role which is the same as the implicit role is not recommended, but not an error by itself."

"The btn token is not a valid role and is therefore ignored."

"Even though the alert role is not allowed, the first token is a valid role and is therefore used."

I think it's a good thing

This works, but perhaps a cleaner way to handle this would be to modify the second condition of the applicability to filter out not just non-visible text content, but also non-text content. That would cause this example to move to the non-applicable section.

Agree, Tom.

But, Applicability has to be objective at this time, so the except non-text content part is under the Expectation section for now.

dan-tripp-siteimprove · 2023-11-09T02:08:01Z


 ```html
-<button aria-label="close">X</button>
+<button aria-label="anything">X</button>


This comes up often around here: when passed examples fail something else.

I like it best when there is a note on the passed example which documents that "something else". In this case that note could be: "This example passes the rule and will fail SC 1.1.1".

We could call these "curve ball passed examples".

To have examples like these, and to document them as such, meets two goals, both important:

It emphasizes why the example passes the rule. (In this case: "to make it clear that really any description would pass this rule", as Kathy put it). I think that this aids understanding, a lot.

It tells everyone that even though this is a "passed example" for this rule, it's not a good example overall, so no one should copy and paste the code.

Jean-Yves did this a lot in the examples for his recent PR 2084:

"Using an explicit role of generic for any element is globally not recommended, but not an error by itself."

"Using an explicit role which is the same as the implicit role is not recommended, but not an error by itself."

"The btn token is not a valid role and is therefore ignored."

"Even though the alert role is not allowed, the first token is a valid role and is therefore used."

I think it's a good thing

add matching characters from act rules glossary

dd8

The updated rules references the #matching-characters glossary definition which says:

A sequence of characters is considered to match another if, after removing leading and trailing space characters and replacing remaining occurrences of one or more space characters with a single space, the two sequences of characters are equal character-by-character, ignoring any differences in letter casing

The link to https://html.spec.whatwg.org/#white_space in the #matching-characters definition is broken so it's not clear which definition of space characters is intended. The various WHATWG specs have moved to a common definition of ASCII whitespace defined here:
https://infra.spec.whatwg.org/#ascii-whitespace

This is different to the Unicode whitespace definition the rule currently uses:
https://www.w3.org/WAI/standards-guidelines/act/rules/2ee8b8/proposed/#whitespace

Notably ASCII whitespace doesn't include   which would be problematic for this example from @dan-tripp-siteimprove

<a aria-label="compose email" href="#">Compose &nbsp;&nbsp;<br> email</a>

Desired behaviour: pass this rule

kengdoj · 2023-12-01T16:19:47Z

Thank you @dd8 for catching that.

I've opened #2144 to update the matching characters definition.

Jym77 · 2023-12-07T13:31:19Z

Call for Review ends on December 21st.

Same org already approved it.

Jym77 · 2023-12-07T14:23:04Z

Removing from Call for Review as two reviewers were from the same organisation…

giacomo-petri · 2023-12-11T08:02:14Z

+This link has [visible][] text does not match the [accessible name][] because there are extra spaces in the accessible name. 
+
+```html
+<a aria-label="Call 1 2 3. 4 5 6. 7 8 9 0." href="tel:1234567890">123.456.7890</a>


Was the inclusion of a full stop at the end of the aria-label attribute value deliberate? If so, do we need to provide clarification regarding its potential impact on the outcome? In the issue description only extra spaces are mentioned.

thanks! I edited the aria-label.

tombrunet · 2024-01-04T16:28:19Z

Added a comment regarding Pass 5. It feels to me like this scenario should be considered inapplicable, but that would require a modification to the applicability. The rule is consistent as-is, but it seems more accurate to say that the non-text content scenario is not applicable to this rule rather than to say that it passes it...

- being more specific with regards to whitespace and  . as per dd8's comment at act-rules#2101 (review) - misc. other edits.

… a new "label in name algorithm". (#2075) * invalid-form-field-value-36b590: updating failed example 2. * Rule visible-label-in-accessible-name-2ee8b8: introducing a new "label in name algorithm". It's intended mostly to handle whitespace and punctuation. * Adding examples to rule presentational-children-no-focusable-content-307n5z * removing Passed Example 15 because it's a duplicate. * - adding frontmatter. (I originally copied this definition from https://github.com/Siteimprove/sanshikan/blob/main/terms/visible-inner-text.md) - changing glossary links' prefixes from "./" to "#". I don't know if the former was working or not. but the latter is the common practice, it seems. * editing example: WAVE -> WCAG * Update pages/glossary/visible-inner-text.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update pages/glossary/visible-inner-text.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * adding mention of innerText * - removing mention of "the rule" from label-in-name-algorithm.md . replacing it with a new idea: the algorithm 'return value' eg. 'returns "is contained"'. - rewording rule expectation. I think that 'For the target element' is better than 'For each target element' because for this rule, the computation of the expecation for each applicable target element is done in isolation from the other applicable targets on the page. It's simpler if the "for loop" over all applicable targets is done by the tool, not the rule. * adding preamble to label-in-name-algorithm.md which mentions what this algorithm is for. * visible-inner-text definition: now normalizing whitespace in the definition. * visible-inner-text: replacing "ASCII whitespace" with "ASCII space character". * adding passed example due to review at #2075 (comment) * handling review thread #2075 (comment) like this: - changing the visible-inner-text definition to treat w/ "display: inline" differently. (treats it differently effectively, not explicitly.) - adding a passed example which shows a corresponding w/ "display: inline" case. * fixing failing test __tests__/link-reference-has-definition.js * fixing failing test _rules/__tests__/testcase-html-hint.js * fixing failing tests in __tests__/spelling.js * fixing more failing tests in __tests__/spelling.js * fixing more failing tests in __tests__/spelling.js * more fixing of failing test(s) in __tests__/spelling.js * adding glossary definition inlined section. * changing example to match kathy's recent merged PR this commit: 3add10e as per review comment: https://github.com/act-rules/act-rules.github.io/pull/2101/files/9590ae3174691417d13a0096e4330a95d8d27357#r1422056763 * adding failed example to emphasize that a word in the middle will cause a rule failure. * . * Fixing mistaken branch/merge. This commit replaces this file with the contents from commit 86a8b09 i.e. upstream/develop. I think that my mistake was: I committed a certain unrelated commit (intended for a feature branch unrelated to this one) onto my fork's develop branch. That was commit 81caf8a. What I should have done at that time was: make that commit onto my feature branch presentational-children-no-focusable-content-307n5z---examples-aug-2023. * fixing failing test spelling.js / retext-repeated-words * Adding some clarity to the algorithm's wording. - being more specific with regards to whitespace and  . as per dd8's comment at #2101 (review) - misc. other edits. * fixing failing test spelling.js * Visible inner text: handling some uncommon whitespace / visibility cases. Cases handled better as of this commit: - <a aria-label="Download specification" href="#">Downloadxspecification</a> - desired visible inner text: "Download specification" - visible inner text before this commit: "Downloadxspecification" - visible inner text as of this commit: "Download specification" - desired == actual. this is good. - <a aria-label="Download specification" href="#">Downloadxspecification</a> - desired visible inner text: "Downloadspecification" - visible inner text before this commit: "Downloadxspecification" - visible inner text as of this commit: "Downloadspecification" - desired == actual. this is good. Case not changed by this commit: - <a aria-label="Download specification" href="#">Downloadxspecification</a> - desired visible inner text: "Downloadspecification" - visible inner text before this commit: "Downloadxspecification" - visible inner text as of this commit: "Downloadxspecification" - desired != actual. this is (still) bad. it violates this assumption of the rule (visible-label-in-accessible-name-2ee8b8.md): "This rule assumes that neither the label nor the visible inner text are rearranged with CSS in some way so that they appear to the user in a different order than they do in the DOM." * - adding assumption to handle spelling and hyphenation. because of #2075 (comment) - adding Unicode case folding and normalization form KD. because of #2075 (comment) - making the word-breaking step of the algorithm generic to more languages than english. because of #2075 (comment) * Assumptions: - adding "whitespace via CSS" clause to address review comment #2075 (comment) - rewording other parts. * Put back removed exceptions * Add missing exxception * minor rewording. based on review. * Adding an assumption about round brackets and the human language. As per review comment #2075 (comment) * Fixing typo. * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Mike Gower <gowerm@ca.ibm.com> * Removing Failed Example 5 because it violates one of the rule's assumptions. Somewhat related to PR review comment #2075 (comment) * Minor wording change. * Replacing some bullet points with a numbered list. because of PR review comment #2075 (comment) * - moving clauses about spelling, hyphenation, and abbreviations from the assumptions to the applicability. as per meeting 2026-02-05. - adding clause to applicability: any widget that contains an image is inapplicable (due to lack of OCR in this rule - would cause a false positive.) - in some html examples: minor formatting fixes. * adding an inapplicable example. non-standard / nonstandard - hyphenation. because of the review comment at #2075 (comment) * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com> * Passed Example 8 - changing wording re: whitespace. * Changing wording on failed example 15, 1 vs. 1a, because of discussion during meeting today. * removing from applicability "The element does not contain any [rendered image resources]". adding corresponding note in background. due to discussion in the meeting today. * adding to algorithm some clarity on string equality check. my idea. * algorithm: - changing unicode wording. class -> category. - excluding "Mark". I don't know how "mark" got in there, and I think it should not have been in there. * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update pages/glossary/label-in-name-algorithm.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * minor tweaks * for language, now linking to whatwg definition. * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * passed example 8: rewording. * Passed Example 11: adding "fragment link" to visible-inner-text:for-text-clause-2. * fixing previous commit * fixing previous commit * tweaking previous commit * another tweak * another tweak * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Passed Example 9: changing from p to div as per Jym's review. Also removing whitespace between the divs. Doing this because that whitespace was introduced accidentally in commit 5617755 (which was a merge). * removing two references to "previous example" * Failed Example 12 (adding href) * removing "same as above" reference. * Update pages/glossary/visible-inner-text.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * using unicode spec notation eg. "U+0028 LEFT PARENTHESIS". * Update pages/glossary/label-in-name-algorithm.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * adding link to unicode categories * Update pages/glossary/label-in-name-algorithm.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update pages/glossary/label-in-name-algorithm.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * moving the "Remove parentheses" step. as per #2075 (comment) this fixes a big problem that has been there since the beginning of this PR i.e. three years. * replacing "sublist" with "contiguous subsequence". as per #2075 (comment) * oops * oops again. * assumptions > brackets > handling a link named "Dune (1984 film)". as per #2075 (comment) * Fix typo and syntax errors * Remove unused definition * fixing passed example 9. AFAICS it was broken accidentally in commit 2f42547 . * manually applying review suggestion from jym at #2075 (comment) * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * adding dfn element , roughly as per review comment at #2075 (comment) * parent commit (before the merge) seemed to break the netlify preview. maybe it's the quotes. this commit is an experiment. * Update pages/glossary/label-in-name-algorithm.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update pages/glossary/label-in-name-algorithm.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * as per #2075 (comment) * fixing reference * Update pages/glossary/visible-inner-text.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * adding 'contiguous subsequence' defn as per #2075 (comment) * more contiguous * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update pages/glossary/label-in-name-algorithm.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * non-text tweak as per #2075 (comment) --------- Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Daniel <dmontalvo@w3.org> Co-authored-by: Mike Gower <gowerm@ca.ibm.com> Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

… a new "label in name algorithm". (#2075) * invalid-form-field-value-36b590: updating failed example 2. * Rule visible-label-in-accessible-name-2ee8b8: introducing a new "label in name algorithm". It's intended mostly to handle whitespace and punctuation. * Adding examples to rule presentational-children-no-focusable-content-307n5z * removing Passed Example 15 because it's a duplicate. * - adding frontmatter. (I originally copied this definition from https://github.com/Siteimprove/sanshikan/blob/main/terms/visible-inner-text.md) - changing glossary links' prefixes from "./" to "#". I don't know if the former was working or not. but the latter is the common practice, it seems. * editing example: WAVE -> WCAG * Update pages/glossary/visible-inner-text.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update pages/glossary/visible-inner-text.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * adding mention of innerText * - removing mention of "the rule" from label-in-name-algorithm.md . replacing it with a new idea: the algorithm 'return value' eg. 'returns "is contained"'. - rewording rule expectation. I think that 'For the target element' is better than 'For each target element' because for this rule, the computation of the expecation for each applicable target element is done in isolation from the other applicable targets on the page. It's simpler if the "for loop" over all applicable targets is done by the tool, not the rule. * adding preamble to label-in-name-algorithm.md which mentions what this algorithm is for. * visible-inner-text definition: now normalizing whitespace in the definition. * visible-inner-text: replacing "ASCII whitespace" with "ASCII space character". * adding passed example due to review at act-rules/act-rules.github.io#2075 (comment) * handling review thread act-rules/act-rules.github.io#2075 (comment) like this: - changing the visible-inner-text definition to treat w/ "display: inline" differently. (treats it differently effectively, not explicitly.) - adding a passed example which shows a corresponding w/ "display: inline" case. * fixing failing test __tests__/link-reference-has-definition.js * fixing failing test _rules/__tests__/testcase-html-hint.js * fixing failing tests in __tests__/spelling.js * fixing more failing tests in __tests__/spelling.js * fixing more failing tests in __tests__/spelling.js * more fixing of failing test(s) in __tests__/spelling.js * adding glossary definition inlined section. * changing example to match kathy's recent merged PR this commit: act-rules/act-rules.github.io@3add10e as per review comment: https://github.com/act-rules/act-rules.github.io/pull/2101/files/9590ae3174691417d13a0096e4330a95d8d27357#r1422056763 * adding failed example to emphasize that a word in the middle will cause a rule failure. * . * Fixing mistaken branch/merge. This commit replaces this file with the contents from commit 86a8b09d8856c8b93894c52d14e6592bdb0ac5d3 i.e. upstream/develop. I think that my mistake was: I committed a certain unrelated commit (intended for a feature branch unrelated to this one) onto my fork's develop branch. That was commit 81caf8a7c954a6869da49443bf5eef015e9b346a. What I should have done at that time was: make that commit onto my feature branch presentational-children-no-focusable-content-307n5z---examples-aug-2023. * fixing failing test spelling.js / retext-repeated-words * Adding some clarity to the algorithm's wording. - being more specific with regards to whitespace and  . as per dd8's comment at act-rules/act-rules.github.io#2101 (review) - misc. other edits. * fixing failing test spelling.js * Visible inner text: handling some uncommon whitespace / visibility cases. Cases handled better as of this commit: - <a aria-label="Download specification" href="#">Downloadxspecification</a> - desired visible inner text: "Download specification" - visible inner text before this commit: "Downloadxspecification" - visible inner text as of this commit: "Download specification" - desired == actual. this is good. - <a aria-label="Download specification" href="#">Downloadxspecification</a> - desired visible inner text: "Downloadspecification" - visible inner text before this commit: "Downloadxspecification" - visible inner text as of this commit: "Downloadspecification" - desired == actual. this is good. Case not changed by this commit: - <a aria-label="Download specification" href="#">Downloadxspecification</a> - desired visible inner text: "Downloadspecification" - visible inner text before this commit: "Downloadxspecification" - visible inner text as of this commit: "Downloadxspecification" - desired != actual. this is (still) bad. it violates this assumption of the rule (visible-label-in-accessible-name-2ee8b8.md): "This rule assumes that neither the label nor the visible inner text are rearranged with CSS in some way so that they appear to the user in a different order than they do in the DOM." * - adding assumption to handle spelling and hyphenation. because of act-rules/act-rules.github.io#2075 (comment) - adding Unicode case folding and normalization form KD. because of act-rules/act-rules.github.io#2075 (comment) - making the word-breaking step of the algorithm generic to more languages than english. because of act-rules/act-rules.github.io#2075 (comment) * Assumptions: - adding "whitespace via CSS" clause to address review comment act-rules/act-rules.github.io#2075 (comment) - rewording other parts. * Put back removed exceptions * Add missing exxception * minor rewording. based on review. * Adding an assumption about round brackets and the human language. As per review comment act-rules/act-rules.github.io#2075 (comment) * Fixing typo. * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Mike Gower <gowerm@ca.ibm.com> * Removing Failed Example 5 because it violates one of the rule's assumptions. Somewhat related to PR review comment act-rules/act-rules.github.io#2075 (comment) * Minor wording change. * Replacing some bullet points with a numbered list. because of PR review comment act-rules/act-rules.github.io#2075 (comment) * - moving clauses about spelling, hyphenation, and abbreviations from the assumptions to the applicability. as per meeting 2026-02-05. - adding clause to applicability: any widget that contains an image is inapplicable (due to lack of OCR in this rule - would cause a false positive.) - in some html examples: minor formatting fixes. * adding an inapplicable example. non-standard / nonstandard - hyphenation. because of the review comment at act-rules/act-rules.github.io#2075 (comment) * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com> * Passed Example 8 - changing wording re: whitespace. * Changing wording on failed example 15, 1 vs. 1a, because of discussion during meeting today. * removing from applicability "The element does not contain any [rendered image resources]". adding corresponding note in background. due to discussion in the meeting today. * adding to algorithm some clarity on string equality check. my idea. * algorithm: - changing unicode wording. class -> category. - excluding "Mark". I don't know how "mark" got in there, and I think it should not have been in there. * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update pages/glossary/label-in-name-algorithm.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * minor tweaks * for language, now linking to whatwg definition. * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * passed example 8: rewording. * Passed Example 11: adding "fragment link" to visible-inner-text:for-text-clause-2. * fixing previous commit * fixing previous commit * tweaking previous commit * another tweak * another tweak * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Passed Example 9: changing from p to div as per Jym's review. Also removing whitespace between the divs. Doing this because that whitespace was introduced accidentally in commit 56177552ff5aac02e26a7b5c9a9a66b38c6bd91e (which was a merge). * removing two references to "previous example" * Failed Example 12 (adding href) * removing "same as above" reference. * Update pages/glossary/visible-inner-text.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * using unicode spec notation eg. "U+0028 LEFT PARENTHESIS". * Update pages/glossary/label-in-name-algorithm.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * adding link to unicode categories * Update pages/glossary/label-in-name-algorithm.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update pages/glossary/label-in-name-algorithm.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * moving the "Remove parentheses" step. as per act-rules/act-rules.github.io#2075 (comment) this fixes a big problem that has been there since the beginning of this PR i.e. three years. * replacing "sublist" with "contiguous subsequence". as per act-rules/act-rules.github.io#2075 (comment) * oops * oops again. * assumptions > brackets > handling a link named "Dune (1984 film)". as per act-rules/act-rules.github.io#2075 (comment) * Fix typo and syntax errors * Remove unused definition * fixing passed example 9. AFAICS it was broken accidentally in commit 2f425473f2108820bc1fe86870a0cc2f3e35c4f1 . * manually applying review suggestion from jym at act-rules/act-rules.github.io#2075 (comment) * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * adding dfn element , roughly as per review comment at act-rules/act-rules.github.io#2075 (comment) * parent commit (before the merge) seemed to break the netlify preview. maybe it's the quotes. this commit is an experiment. * Update pages/glossary/label-in-name-algorithm.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update pages/glossary/label-in-name-algorithm.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * as per act-rules/act-rules.github.io#2075 (comment) * fixing reference * Update pages/glossary/visible-inner-text.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * adding 'contiguous subsequence' defn as per act-rules/act-rules.github.io#2075 (comment) * more contiguous * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update _rules/visible-label-in-accessible-name-2ee8b8.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * Update pages/glossary/label-in-name-algorithm.md Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> * non-text tweak as per act-rules/act-rules.github.io#2075 (comment) --------- Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com> Co-authored-by: Daniel <dmontalvo@w3.org> Co-authored-by: Mike Gower <gowerm@ca.ibm.com> Co-authored-by: Kathy Eng <kengdoj@users.noreply.github.com>

Update visible-label-in-accessible-name-2ee8b8.md

0267d32

kengdoj marked this pull request as draft August 21, 2023 23:40

kengdoj added 2 commits August 21, 2023 19:54

Update visible-label-in-accessible-name-2ee8b8.md

ffd53a2

Update visible-label-in-accessible-name-2ee8b8.md

c929457

kengdoj commented Aug 22, 2023

View reviewed changes

Comment thread _rules/visible-label-in-accessible-name-2ee8b8.md Outdated

Update _rules/visible-label-in-accessible-name-2ee8b8.md

9590ae3

tbostic32 reviewed Aug 31, 2023

View reviewed changes

Comment thread _rules/visible-label-in-accessible-name-2ee8b8.md Outdated

Comment thread _rules/visible-label-in-accessible-name-2ee8b8.md

Jym77 previously approved these changes Sep 28, 2023

View reviewed changes

dan-tripp-siteimprove self-requested a review November 9, 2023 01:40

dan-tripp-siteimprove approved these changes Nov 9, 2023

View reviewed changes

Update _rules/visible-label-in-accessible-name-2ee8b8.md

f19e9eb

kengdoj commented Nov 9, 2023

View reviewed changes

Comment thread _rules/visible-label-in-accessible-name-2ee8b8.md Outdated

Update _rules/visible-label-in-accessible-name-2ee8b8.md

b4d18a5

0066135 approved these changes Nov 16, 2023

View reviewed changes

kengdoj marked this pull request as ready for review November 28, 2023 23:34

Jym77 and others added 2 commits November 30, 2023 11:52

Merge branch 'develop' into kengdoj-labelinname

d1b8f91

Update visible-label-in-accessible-name-2ee8b8.md

818d342

add matching characters from act rules glossary

dd8 reviewed Dec 1, 2023

View reviewed changes

Merge branch 'develop' into kengdoj-labelinname

3401bfb

Jym77 added the Review call 2 weeks Call for review for new rules and big changes label Dec 7, 2023

Jym77 removed the Review call 2 weeks Call for review for new rules and big changes label Dec 7, 2023

giacomo-petri reviewed Dec 11, 2023

View reviewed changes

kengdoj commented Dec 12, 2023

View reviewed changes

Comment thread _rules/visible-label-in-accessible-name-2ee8b8.md Outdated

Update _rules/visible-label-in-accessible-name-2ee8b8.md

3add10e

kengdoj requested review from dd8 and giacomo-petri December 12, 2023 19:17

WilcoFiers approved these changes Dec 21, 2023

View reviewed changes

tbostic32 approved these changes Dec 21, 2023

View reviewed changes

carlosapaduarte approved these changes Dec 21, 2023

View reviewed changes

colabottles approved these changes Jan 4, 2024

View reviewed changes

tombrunet approved these changes Jan 5, 2024

View reviewed changes

Merge branch 'develop' into kengdoj-labelinname

f3f701b

Jym77 merged commit 1db4aaf into develop Jan 11, 2024

Jym77 deleted the kengdoj-labelinname branch January 11, 2024 15:10

Jym77 mentioned this pull request Jan 22, 2024

SIA-R14: use stronger character matching algorithm Siteimprove/alfa#1558

Open

dbjorge mentioned this pull request Jan 26, 2024

label-content-name-mismatch should not treat hyphenated labels as matching non-hyphenated content dequelabs/axe-core#4311

Open

Uh oh!

Conversation

kengdoj commented Aug 21, 2023

Pull Request Etiquette

When creating PR:

After creating PR:

When merging a PR:

How to Review And Approve

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jym77 left a comment

Choose a reason for hiding this comment

Uh oh!

Jym77 Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

kengdoj Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dan-tripp-siteimprove Nov 9, 2023

Choose a reason for hiding this comment

Uh oh!

tombrunet Jan 4, 2024

Choose a reason for hiding this comment

Uh oh!

kengdoj Jan 4, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dan-tripp-siteimprove Nov 9, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dd8 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kengdoj commented Dec 1, 2023

Uh oh!

Jym77 commented Dec 7, 2023

Uh oh!

Jym77 commented Dec 7, 2023

Uh oh!

giacomo-petri Dec 11, 2023

Choose a reason for hiding this comment

Uh oh!

kengdoj Dec 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tombrunet commented Jan 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

kengdoj Oct 30, 2023 •

edited

Loading

dd8 left a comment •

edited

Loading

kengdoj Dec 12, 2023 •

edited

Loading