Skip to content

ci: move argus to the aao secretariat app identity #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bokelley wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: move argus to the aao secretariat app identity #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ai-review/expert-adcp-reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Argus — Expert PR Reviewer (Java SDK)

You are **Argus**, the expert PR reviewer for `adcontextprotocol/adcp-sdk-java`. You review pull requests **in the voice of Brian O'Kelley** (`bokelley` — primary maintainer of the AdCP protocol). Apply his standing engineering bar.
You are **Argus**, the expert PR reviewer for `adcontextprotocol/adcp-sdk-java`. Argus is the review desk of the AAO Secretariat, serving the AdCP Working Group. Apply the WG constitution appended to this prompt, and cite decision records (`DR-NNNN` in the spec repo's `governance/decisions/`) when a question is settled precedent.

This is a real review on a real PR. You will post it directly via `gh pr review`. Do not output the review as preamble — emit it as the body of the `gh pr review` command at the end.

Expand Down
33 changes: 22 additions & 11 deletions .github/workflows/ai-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,17 @@ name: AI PR Review (Argus)
# Argus is an LLM PR reviewer that posts an `--approve`, `--comment`, or
# `--request-changes` review on every non-dependabot PR. It reads the diff,
# delegates to subagents when relevant (ad-tech-protocol-expert,
# security-reviewer, code-reviewer, etc.), and writes the review in
# bokelley's voice.
# security-reviewer, code-reviewer, etc.). Argus is the AAO Secretariat's
# review desk: it applies the WG constitution (fetched from
# adcontextprotocol/adcp@main at review time and appended to the prompt).
#
# Reviews are posted with the IPR GitHub App installation token so fork PRs can
# be reviewed and the resulting bot review is attributable to the same App that
# owns this repo's IPR workflow.
# Reviews are posted with the AAO Secretariat GitHub App installation token so
# fork PRs can be reviewed and the review is attributable to the Secretariat
# (`aao-secretariat[bot]`).
#
# Required secrets:
# IPR_APP_ID — already configured for the IPR workflow
# IPR_APP_PRIVATE_KEY — already configured for the IPR workflow
# SECRETARIAT_APP_ID — org-level, AAO Secretariat GitHub App
# SECRETARIAT_APP_PRIVATE_KEY — org-level, AAO Secretariat GitHub App
# ANTHROPIC_API_KEY — Anthropic API key for claude-code-action
#
# Adapted from adcontextprotocol/adcp's Argus workflow.
Expand Down Expand Up @@ -79,8 +80,8 @@ jobs:
id: notice-token
uses: actions/create-github-app-token@d72941d797fd3113feb6b93fd0dec494b13a2547 # v1
with:
app-id: ${{ secrets.IPR_APP_ID }}
private-key: ${{ secrets.IPR_APP_PRIVATE_KEY }}
app-id: ${{ secrets.SECRETARIAT_APP_ID }}
private-key: ${{ secrets.SECRETARIAT_APP_PRIVATE_KEY }}
permission-contents: read
permission-issues: write

Expand Down Expand Up @@ -145,10 +146,20 @@ jobs:
PROMPT_BODY="$(git show "${BASE_SHA}:.github/ai-review/expert-adcp-reviewer.md" \
| sed '/^This is a real review on a real PR\./,/^$/d' \
| awk '/^## Picking the action$/ { exit } { print }')"
# The WG constitution is governance owned by the spec repo. Fetch it
# from adcontextprotocol/adcp@main at review time — never from this
# repo or the PR — so Argus always applies the current constitution.
CONSTITUTION="$(curl -sf https://raw.githubusercontent.com/adcontextprotocol/adcp/main/.agents/wg/constitution.md || true)"
SENTINEL="ARGUS_$(openssl rand -hex 8)_EOF"
{
echo "ARGUS_PROMPT<<${SENTINEL}"
echo "$PROMPT_BODY"
if [ -n "$CONSTITUTION" ]; then
echo ''
echo '## WG constitution (from adcontextprotocol/adcp@main)'
echo ''
echo "$CONSTITUTION"
fi
echo ''
echo '---'
echo ''
Expand Down Expand Up @@ -220,8 +231,8 @@ jobs:
if: always() && steps.self-mod.outputs.touches != 'true'
uses: actions/create-github-app-token@d72941d797fd3113feb6b93fd0dec494b13a2547 # v1
with:
app-id: ${{ secrets.IPR_APP_ID }}
private-key: ${{ secrets.IPR_APP_PRIVATE_KEY }}
app-id: ${{ secrets.SECRETARIAT_APP_ID }}
private-key: ${{ secrets.SECRETARIAT_APP_PRIVATE_KEY }}
permission-contents: read
permission-pull-requests: write
permission-issues: write
Expand Down
Loading