Skip to content

feat(config): add excludedPathPrefixes support to handlers config (LLMO-6132) #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhavkuma wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(config): add excludedPathPrefixes support to handlers config (LLMO-6132) #1817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/spacecat-shared-data-access/src/models/site/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,7 @@ export const configSchema = Joi.object({
mentions: Joi.object().pattern(Joi.string(), Joi.array().items(Joi.string())),
excludedURLs: Joi.array().items(Joi.string()),
autofixExcludedURLs: Joi.array().items(Joi.string()),
excludedPathPrefixes: Joi.array().items(Joi.string()),
manualOverwrites: Joi.array().items(Joi.object({
brokenTargetURL: Joi.string().optional(),
targetURL: Joi.string().optional(),
Expand Down Expand Up @@ -577,6 +578,7 @@ export const Config = (data = {}) => {
self.getImports = () => state.imports;
self.getExcludedURLs = (type) => state?.handlers?.[type]?.excludedURLs;
self.getAutofixExcludedURLs = (type) => state?.handlers?.[type]?.autofixExcludedURLs;
self.getExcludedPathPrefixes = (type) => state?.handlers?.[type]?.excludedPathPrefixes;
self.getManualOverwrites = (type) => state?.handlers?.[type]?.manualOverwrites;
self.getFixedURLs = (type) => state?.handlers?.[type]?.fixedURLs;
self.getIncludedURLs = (type) => state?.handlers?.[type]?.includedURLs;
Expand Down Expand Up @@ -882,6 +884,12 @@ export const Config = (data = {}) => {
state.handlers[type].autofixExcludedURLs = autofixExcludedURLs;
};

self.updateExcludedPathPrefixes = (type, excludedPathPrefixes) => {
state.handlers = state.handlers || {};
state.handlers[type] = state.handlers[type] || {};
state.handlers[type].excludedPathPrefixes = excludedPathPrefixes;
};

self.updateManualOverwrites = (type, manualOverwrites) => {
state.handlers = state.handlers || {};
state.handlers[type] = state.handlers[type] || {};
Expand Down
14 changes: 14 additions & 0 deletions packages/spacecat-shared-data-access/test/unit/models/site/config.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,19 @@ describe('Config Tests', () => {
expect(config.getAutofixExcludedURLs('non-existent-handler')).to.be.undefined;
});

it('correctly updates the excluded path prefixes', () => {
const config = Config();
config.updateExcludedPathPrefixes('prerender', ['/jp/ja', '/de/de']);

const excludedPathPrefixes = config.getExcludedPathPrefixes('prerender');
expect(excludedPathPrefixes).to.deep.equal(['/jp/ja', '/de/de']);
});

it('returns undefined for excluded path prefixes when handler is not present', () => {
const config = Config();
expect(config.getExcludedPathPrefixes('non-existent-handler')).to.be.undefined;
});

it('correctly updates the manual overrides', () => {
const config = Config();
const manualOverwrites = [
Expand Down Expand Up @@ -476,6 +489,7 @@ describe('Config Tests', () => {
expect(config.getHandlerConfig('404')).to.be.undefined;
expect(config.getExcludedURLs('404')).to.be.undefined;
expect(config.getAutofixExcludedURLs('404')).to.be.undefined;
expect(config.getExcludedPathPrefixes('404')).to.be.undefined;
expect(config.getManualOverwrites('404')).to.be.undefined;
expect(config.getFixedURLs('404')).to.be.undefined;
expect(config.getIncludedURLs('404')).to.be.undefined;
Expand Down
Loading