Skip to content

fix: decision request/response schemas - #116

Open
georgantasp wants to merge 1 commit into
adzerk:masterfrom
janetechinc:fixSchemaForDecisionResponse
Open

fix: decision request/response schemas#116
georgantasp wants to merge 1 commit into
adzerk:masterfrom
janetechinc:fixSchemaForDecisionResponse

Conversation

@georgantasp

@georgantasp georgantasp commented Jul 7, 2026

Copy link
Copy Markdown

Fixes modeling in the Decision request/response.

  • Connect the DecisionResponse schema to the Decision schema
  • Create schemas for
    • ContentData
    • AdQuery and sub-entities

@georgantasp
georgantasp force-pushed the fixSchemaForDecisionResponse branch from 42552c7 to 9cf99bd Compare July 7, 2026 14:08
@tomascasas

Copy link
Copy Markdown
Contributor

Thanks for your PRs, your contribution was the motivation and starting point for this PR as you comment.
That and a few additions and improvements were verified against the implemented code.
Thank you!

@georgantasp

Copy link
Copy Markdown
Author

Thanks @tomascasas. Any reason you chose to leave out the ContentData and AdQuery schemas I created?

…ixes

[SUPPORT-1613] Fix OpenAPI spec validation issues and align schemas with implementation
@georgantasp
georgantasp force-pushed the fixSchemaForDecisionResponse branch from 9cf99bd to f568ec6 Compare July 20, 2026 15:45
@georgantasp

georgantasp commented Jul 20, 2026

Copy link
Copy Markdown
Author

Rebased this branch to highlight the pieces I'm still looking for

@georgantasp georgantasp changed the title fix: decision response decisions with schema fix: decision request/response schemas Jul 20, 2026
@tomascasas

Copy link
Copy Markdown
Contributor

Thanks @tomascasas. Any reason you chose to leave out the ContentData and AdQuery schemas I created?

Let me get back to you with a proper answer. We are troubleshooting an issue with TS generation of anyOf/oneOf that had to rollback for DecisionResponse to object for the time being.

I added your rebased PR to the list of TO-DOs before we have that PR out for review. Thanks for following up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants