A few CommonSpawnData improvements#1883
Merged
Haselnussbomber merged 1 commit intoJul 15, 2026
Merged
Conversation
EventId should be the EventId type, so I added a TODO for that. Unk5E is an index into the Behavior Excel sheet (I'm unsure what for, but I'm also not super familiar with that system.) SpawnIndex is used, just not in InitCommon. Unk79 turns out to be the same Visibility/IsHidden flag from SpawnOject/SpawnTreasure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventId should be the EventId type, so I added a TODO for that. Unk5E is an index into the Behavior Excel sheet (I'm unsure what for, but I'm also not super familiar with that system.) SpawnIndex is used, just not in InitCommon. Unk79 turns out to be the same Visibility/IsHidden flag from SpawnOject/SpawnTreasure.