fix: make atelet / ateom use actor UID for its internal bookkeeping#438
Open
Eric Bishop (ericdbishop) wants to merge 6 commits into
Open
fix: make atelet / ateom use actor UID for its internal bookkeeping#438Eric Bishop (ericdbishop) wants to merge 6 commits into
Eric Bishop (ericdbishop) wants to merge 6 commits into
Conversation
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
Signed-off-by: Eric Bishop <ericbish.dev@gmail.com>
Eric Bishop (ericdbishop)
marked this pull request as ready for review
July 15, 2026 15:02
Haven Xia (HavenXia)
self-requested a review
July 16, 2026 16:45
| // Record the (manifest-pinned) sandbox binaries on-node so a subsequent | ||
| // Checkpoint of this restored actor can re-pin the same version. | ||
| if err := writeSandboxRecord(atespace, actorName, sandboxRec); err != nil { | ||
| if err := writeSandboxRecord(req.ActorUid, sandboxRec); err != nil { |
Collaborator
There was a problem hiding this comment.
nit: can just use actorUID
| // so a later Checkpoint can pin the same version into the snapshot manifest. | ||
| SandboxAssets sandbox_assets = 7; | ||
|
|
||
| string actor_uid = 8; |
Collaborator
There was a problem hiding this comment.
I think in this stage, proto renumbering is fine, can you move actor_uid below actor_name to keep the readability?
Same for all protos you modified in this PR.
Haven Xia (HavenXia)
requested changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #422
Gen AI disclosure: Used GPT-5.6 sol to learn about the codebase / issue context, enumerate where the actor name/atespace were being used for bookkeeping, and for adversarial review of my code.