feat(log-enrichment): add custom session ID attribute for enriched spans#181
Open
AaronProbha18 wants to merge 1 commit into
Open
feat(log-enrichment): add custom session ID attribute for enriched spans#181AaronProbha18 wants to merge 1 commit into
AaronProbha18 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR stops storing session IDs in the OpenTelemetry semantic convention attribute
gen_ai.agent.nameand instead records them in a repository-specific custom attribute,agentevals.session.id.Previously, the log enrichment pipeline wrote the session ID into
gen_ai.agent.name, overwriting legitimate agent names from SDK and OTLP telemetry. This caused downstream metadata extraction to incorrectly report the session ID as the agent name.Changes
agentevals.session.id.agentevals.session.id.gen_ai.agent.namefor genuine agent names supplied by telemetry.