fix(harness): add per-session interrupt methods to HarnessAgent - #2600
Open
xy-ygz wants to merge 1 commit into
Open
fix(harness): add per-session interrupt methods to HarnessAgent#2600xy-ygz wants to merge 1 commit into
xy-ygz wants to merge 1 commit into
Conversation
HarnessAgent only forwarded no-arg interrupt(), which routed to ReActAgent's deprecated default session. Add RuntimeContext and (userId, sessionId) overloads aligned with clearContext(). Fixes agentscope-ai#2509
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
oss-maintainer
left a comment
oss-maintainer
left a comment
Collaborator
There was a problem hiding this comment.
Summary
This PR modifies 2 files with 121 lines of diff.
Observations
- Files changed: 2
- Test coverage: ✅ Tests included
- CLA: ✅ Signed
Suggestions
- Please ensure all public API changes are backward compatible
- Consider adding unit tests for new logic paths
Automated review by github-manager-bot
AgentScopeJavaBot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HarnessAgent only forwarded no-arg interrupt(), which routed to ReActAgent's deprecated default session. Add RuntimeContext and (userId, sessionId) overloads aligned with clearContext().
Fixes #2509
AgentScope-Java Version
2.0.1-SNAPSHOT (
main)Description
Fixes #2509.
Background:
ReActAgentalready supports per-session interrupt viainterrupt(RuntimeContext)andinterrupt(String userId, String sessionId), butHarnessAgentonly forwarded the deprecated no-arginterrupt()/interrupt(Msg), which always routed to the default session slot. In multi-tenant deployments, callers could not interrupt a specific(userId, sessionId)session throughHarnessAgent.Changes:
HarnessAgent, delegating to the internalReActAgent:interrupt(RuntimeContext ctx)interrupt(RuntimeContext ctx, Msg msg)interrupt(String userId, String sessionId)interrupt(String userId, String sessionId, Msg msg)clearContext().HarnessAgentTestverifying session isolation.How to test:
mvn -pl agentscope-harness spotless:apply mvn -pl agentscope-harness -am test \ -Dtest=HarnessAgentTest#interruptWithUserIdAndSessionIdTargetsOnlyThatSession,HarnessAgentTest#interruptWithRuntimeContextDelegatesToReActAgent \ -Dsurefire.failIfNoSpecifiedTests=falseChecklist
mvn spotless:applymvn test— targetedHarnessAgentTestinterrupt tests: 2 passed, 0 failures)