fix(openai): normalize strict structured output schemas - #2608
Open
steven-ji wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
steven-ji
marked this pull request as ready for review
August 7, 2026 15:16
oss-maintainer
left a comment
Collaborator
There was a problem hiding this comment.
Summary
This PR modifies 2 files with 310 lines of diff.
Observations
- Files changed: 2
- Test coverage: ✅ Tests included
- CLA: ✅ Signed
Suggestions
- Please ensure all public API changes are backward compatible
- Consider adding unit tests for new logic paths
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
additionalProperties: falseand include every declared property inrequiredfor each object schema$defswithout mutating the caller-provided schemaagent.call(..., Class)schema path and nested schemasRoot cause
ReActAgentenables strict mode for native structured output, while the general JSON Schema generator leaves fields optional by default and does not forbid additional properties. OpenAI rejects that schema whenstrict: trueis used.Impact
OpenAI calls using typed structured outputs are no longer rejected for missing
additionalProperties: falseor incomplete/missingrequiredarrays. Other model providers keep their existing schema generation behavior because normalization happens at the OpenAI formatter boundary.Validation
mvn -pl agentscope-extensions/agentscope-extensions-model/agentscope-extensions-model-openai -am -Dtest=OpenAIChatFormatterTest -Dsurefire.failIfNoSpecifiedTests=false testFixes #2548