fix(harness): close test agents before temp workspace cleanup - #2669
Closed
zouyx wants to merge 2 commits into
Closed
fix(harness): close test agents before temp workspace cleanup#2669zouyx wants to merge 2 commits into
zouyx wants to merge 2 commits into
Conversation
Collaborator
Author
|
This PR for fix main CI fail |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses flaky Harness test failures where JUnit deletes @TempDir workspaces while HarnessAgent background session/transcript writes are still draining by explicitly closing agents before temp directory cleanup.
Changes:
- Track
HarnessAgentinstances created by the affected tests. - Close tracked agents in
@AfterEachto ensure background writes are drained before@TempDircleanup. - Preserve restoration behavior for
agentscope.state.homein the subagent stream tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| agentscope-harness/src/test/java/io/agentscope/harness/agent/HarnessAgentSubagentStreamTest.java | Track created agents and close them in @AfterEach before restoring agentscope.state.home. |
| agentscope-harness/src/test/java/io/agentscope/harness/agent/HarnessAgentDynamicHookBuilderTest.java | Track created agents and close them in @AfterEach to avoid TempDir deletion races. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+83
to
+85
| void closeAgents() { | ||
| agents.forEach(HarnessAgent::close); | ||
| } |
Comment on lines
+84
to
+86
| try { | ||
| agents.forEach(HarnessAgent::close); | ||
| } finally { |
AgentScopeJavaBot
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.1-SNAPSHOT
Description
Fixes flaky GitHub Actions failures in Harness tests caused by JUnit deleting
@TempDirworkspaces whileHarnessAgentbackground session/transcript writes are still draining.HarnessAgentcreated by the affected tests.@AfterEachbefore JUnit cleans temporary directories.agentscope.state.homein subagent stream tests.Testing
mvn -pl agentscope-harness -am -Dtest=HarnessAgentSubagentStreamTest,HarnessAgentDynamicHookBuilderTest test./.github/scripts/check-shade-and-bom-sync.shmvn -T1 clean verify(in progress)Checklist
mvn spotless:apply