Skip to content

G4-E1: exclude.branches pattern is 111 chars (>MAX_BRANCH_PATTERN_LENGTH=100) - expect SCAN despite label=skip-scan matching exclude.labels - #58

Open
alan-hacktron wants to merge 1 commit into
mainfrom
g4-e1-src
Open

G4-E1: exclude.branches pattern is 111 chars (>MAX_BRANCH_PATTERN_LENGTH=100) - expect SCAN despite label=skip-scan matching exclude.labels#58
alan-hacktron wants to merge 1 commit into
mainfrom
g4-e1-src

Conversation

@alan-hacktron

Copy link
Copy Markdown
Owner

This PR is labeled skip-scan, which matches a perfectly valid exclude.labels: [skip-scan] rule in the same config. But the config also contains an exclude.branches pattern that's 111 characters (over the 100-char isSafeBranchPattern limit). Because zod validates the whole hacktronConfigSchema object atomically, one invalid field fails the ENTIRE config, not just branches — so exclude.labels never takes effect either. Expected: SCAN (fail-open), plus a bot comment noting the malformed config.

@hacktron-app-stg

Copy link
Copy Markdown

Hacktron config could not be read

schema validation failed: exclude.branches: each pattern must be at most 100 characters with at most 5 wildcards and cannot contain advanced glob characters (like braces, brackets, parentheses, or extglobs)

Hacktron is scanning this PR using your organization's default settings instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant