Skip to content

G4-E7: exclude.keywords has 51 entries - IMPORTANT: this specifically tests whether the PR #692 max-cap fix is deployed yet - #64

Open
alan-hacktron wants to merge 1 commit into
mainfrom
g4-e7-src
Open

G4-E7: exclude.keywords has 51 entries - IMPORTANT: this specifically tests whether the PR #692 max-cap fix is deployed yet#64
alan-hacktron wants to merge 1 commit into
mainfrom
g4-e7-src

Conversation

@alan-hacktron

Copy link
Copy Markdown
Owner

Before PR #692, exclude/include keywords/labels/authors had no .max() at all — this array would have parsed as VALID under the old schema. After #692, it's capped at MAX_SCAN_FILTER_ITEMS=50, so this 51-entry array should fail validation and invalidate the whole config, same as E1-E6.

This PR is a deployment probe, not just a correctness test:

  • If #692's fix is live: config is invalid -> SCAN (fail-open), plus a malformed-config bot comment.
  • If #692's fix is NOT yet deployed: config is still considered valid under the old unbounded schema -> exclude.labels: [skip-scan] applies normally -> EXCLUDE, no malformed-config comment.

Check which one actually happens before assuming the fix is live in whatever environment scans this repo.

@hacktron-app-stg

Copy link
Copy Markdown

Hacktron config could not be read

schema validation failed: exclude.keywords: Too big: expected array to have <=50 items

Hacktron is scanning this PR using your organization's default settings instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant