Fix simultaneous Gröbner basis computation#289
Conversation
|
Many thanks! |
4f15bc9 to
af258d1
Compare
06c23c5 to
cc7da4d
Compare
|
Last week, I've tested this PR on an ARM Neoverse N1 with 128 GB of RAM. Based on a set of 102 examples from https://gitlab.lip6.fr/eder/msolve-examples, the results show that the binary built from this PR achieved better performance in 53.9% of cases, with performance differences appearing only at the percentile level. Each example is solved using 8 threads and solely at the level of Gröbner bases; no real root isolation is performed. |
|
Same behaviour for my tests. |
|
Yes, I think it is ready to be merged. Many thanks! |
|
@wegank So I can move this PR from "draft" to "ready for review" and merge it, also from your side, right? |
|
We will do a bugfix release first, then handle this PR. |
This PR allows implementing dispatches for
{initial_input,initial_gens,monomial,spair,hcm}_cmpusing an immutable function. Note that this is the minimal breaking change in the context of #288.