Skip to content

Fix simultaneous Gröbner basis computation#289

Merged
ederc merged 2 commits into
algebraic-solving:masterfrom
wegank:threads-fix-0
Jul 14, 2026
Merged

Fix simultaneous Gröbner basis computation#289
ederc merged 2 commits into
algebraic-solving:masterfrom
wegank:threads-fix-0

Conversation

@wegank

@wegank wegank commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

This PR allows implementing dispatches for {initial_input,initial_gens,monomial,spair,hcm}_cmp using an immutable function. Note that this is the minimal breaking change in the context of #288.

@jerebertho

jerebertho commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Many thanks!
CI / FLINT had a lot of errors, which is very weird.

@wegank
wegank force-pushed the threads-fix-0 branch 2 times, most recently from 4f15bc9 to af258d1 Compare March 16, 2026 09:01
@wegank
wegank marked this pull request as draft March 16, 2026 14:34
@wegank
wegank force-pushed the threads-fix-0 branch 2 times, most recently from 06c23c5 to cc7da4d Compare March 28, 2026 20:15
@wegank

wegank commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Last week, I've tested this PR on an ARM Neoverse N1 with 128 GB of RAM. Based on a set of 102 examples from https://gitlab.lip6.fr/eder/msolve-examples, the results show that the binary built from this PR achieved better performance in 53.9% of cases, with performance differences appearing only at the percentile level. Each example is solved using 8 threads and solely at the level of Gröbner bases; no real root isolation is performed.

@ederc

ederc commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Same behaviour for my tests.
@mohabsafey do you think that's ready to be merged?

@mohabsafey

Copy link
Copy Markdown
Contributor

Yes, I think it is ready to be merged. Many thanks!

@ederc

ederc commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@wegank So I can move this PR from "draft" to "ready for review" and merge it, also from your side, right?

@wegank
wegank marked this pull request as ready for review July 6, 2026 20:21
@wegank wegank changed the title Add monomial ordering to hash table Fix simultaneous Gröbner basis computation Jul 6, 2026
@ederc

ederc commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

We will do a bugfix release first, then handle this PR.

@ederc
ederc merged commit 43b9378 into algebraic-solving:master Jul 14, 2026
10 checks passed
@wegank
wegank deleted the threads-fix-0 branch July 14, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants