Skip to content

Bug fix in the lifting of grevlex GBs over QQ #349

Merged
ederc merged 3 commits into
algebraic-solving:masterfrom
mohabsafey:bug-gb-qq
Jul 6, 2026
Merged

Bug fix in the lifting of grevlex GBs over QQ #349
ederc merged 3 commits into
algebraic-solving:masterfrom
mohabsafey:bug-gb-qq

Conversation

@mohabsafey

Copy link
Copy Markdown
Contributor
  • I made a mistake in the stopping criterion which was not general enough (I was basically checking stability on the last polynomial, expectedly with the largest coefficients).
    This would end up with an infinite loop if some intermediate polynomial did not satisfy the stability condition.

This PR solves this bug and brings a corresponding test file

@ederc
ederc merged commit 8f18ac6 into algebraic-solving:master Jul 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants