fix: backport legacy observe grant removal - #251
Open
alongubkin wants to merge 1 commit into
Open
Conversation
Existing prepared stacks contain the account-wide observe grant that older managers inserted automatically. The opt-in observation change correctly stops generating it, but compatibility checks then reject every update as permission drift. Ignore only that exact named grant on the old management side. Additions, named profiles, inline permission sets, other grants, and permission modes remain protected. Refs ALIEN-388
Greptile SummaryBackports compatibility handling that permits removal of the legacy automatic
Confidence Score: 5/5The PR appears safe to merge, with the legacy compatibility exemption constrained to the intended old management grant. The new comparison asymmetrically removes only the exact named
|
| Filename | Overview |
|---|---|
| crates/alien-preflights/src/compatibility/permission_profiles_unchanged.rs | Adds narrowly scoped legacy-grant normalization and regression tests without weakening checks for unrelated permission changes. |
| crates/alien-preflights/src/mutations/management_permission_profile.rs | Exposes the existing observe permission-set identifier within the crate so compatibility logic can reuse the canonical value. |
Reviews (1): Last reviewed commit: "fix: allow legacy observe grant removal" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
observe/observeremoval compatibility fix onto the Alien revision currently consumed by Platform47eb8f69binding changes into the urgent production deploymentValidation
cargo test -p alien-preflights compatibility::permission_profiles_unchanged— 15 passedLinear: ALIEN-388