Skip to content

fix: backport legacy observe grant removal - #251

Open
alongubkin wants to merge 1 commit into
mainfrom
alon/alien-388-backport-legacy-observe-removal
Open

fix: backport legacy observe grant removal#251
alongubkin wants to merge 1 commit into
mainfrom
alon/alien-388-backport-legacy-observe-removal

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Summary

  • backport the legacy automatic observe/observe removal compatibility fix onto the Alien revision currently consumed by Platform
  • avoid pulling unrelated post-47eb8f69 binding changes into the urgent production deployment

Validation

  • cargo test -p alien-preflights compatibility::permission_profiles_unchanged — 15 passed

Linear: ALIEN-388

Existing prepared stacks contain the account-wide observe grant that older managers inserted automatically. The opt-in observation change correctly stops generating it, but compatibility checks then reject every update as permission drift.

Ignore only that exact named grant on the old management side. Additions, named profiles, inline permission sets, other grants, and permission modes remain protected.

Refs ALIEN-388
@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown

Greptile Summary

Backports compatibility handling that permits removal of the legacy automatic observe/observe grant only from management permissions.

  • Compares old management profiles after omitting the exact legacy named grant.
  • Allows an observe-only legacy management profile to return to automatic management.
  • Keeps additions, named-profile changes, inline permission sets, and other management drift protected.
  • Adds regression coverage for the permitted and rejected transitions.

Confidence Score: 5/5

The PR appears safe to merge, with the legacy compatibility exemption constrained to the intended old management grant.

The new comparison asymmetrically removes only the exact named observe/observe reference from old management permissions, while current stack mutation prevents that grant from entering the new application stack and all other permission drift remains checked.

Important Files Changed

Filename Overview
crates/alien-preflights/src/compatibility/permission_profiles_unchanged.rs Adds narrowly scoped legacy-grant normalization and regression tests without weakening checks for unrelated permission changes.
crates/alien-preflights/src/mutations/management_permission_profile.rs Exposes the existing observe permission-set identifier within the crate so compatibility logic can reuse the canonical value.

Reviews (1): Last reviewed commit: "fix: allow legacy observe grant removal" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant