Skip to content

fix(ci): requalify exact merged release commits - #263

Merged
alongubkin merged 2 commits into
mainfrom
alon/alien-410-allow-exact-merged-release-commit-requalification
Jul 30, 2026
Merged

fix(ci): requalify exact merged release commits#263
alongubkin merged 2 commits into
mainfrom
alon/alien-410-allow-exact-merged-release-commit-requalification

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Summary

  • require workflow-dispatch requalification to target the exact merged release commit
  • compare that commit with its first parent, not the PR’s potentially stale base SHA
  • preserve the version-only release check while allowing concurrent main changes that landed before the squash merge

Validation

  • parsed workflow YAML
  • verified PR chore: release v3.3.0 #260 merge metadata resolves to df0b29fe
  • verified df0b29fe^..df0b29fe contains only allowed release-version files

Linear: ALIEN-410

Comment thread .github/workflows/release-qualification.yml
@greptile-apps

greptile-apps Bot commented Jul 30, 2026

Copy link
Copy Markdown

Greptile Summary

The workflow-dispatch requalification path now validates the exact merged release commit.

  • Filters commit-associated pull requests by both the main base branch and exact merge SHA.
  • Uses the merged commit’s first parent as the release-version comparison base.
  • Rejects dispatches that do not resolve to the exact merged release commit.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
.github/workflows/release-qualification.yml The dispatch path now selects the exact merged PR and compares its merge commit against its first parent, resolving the previously reported stale or incorrect PR-selection behavior.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Dispatch["Workflow dispatch with exact source SHA"] --> Lookup["Look up pull requests associated with commit"]
  Lookup --> Filter["Filter for main PR with matching merge SHA"]
  Filter -->|No exact match| Reject["Reject requalification"]
  Filter -->|Exact match| Parent["Resolve commit's first parent"]
  Parent --> Compare["Compare merged commit against first parent"]
  Compare -->|Only allowed version files changed| Qualify["Run release qualification"]
  Compare -->|Unexpected files changed| Reject
Loading

Reviews (2): Last reviewed commit: "fix(ci): select matching release merge a..." | Re-trigger Greptile

@alongubkin
alongubkin merged commit 0d4f932 into main Jul 30, 2026
23 of 25 checks passed
@alongubkin
alongubkin deleted the alon/alien-410-allow-exact-merged-release-commit-requalification branch July 30, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant