Skip to content

fix(ci): publish an explicit qualification run - #264

Open
alongubkin wants to merge 1 commit into
mainfrom
alon/alien-411-publish-from-an-explicit-release-qualification-run
Open

fix(ci): publish an explicit qualification run#264
alongubkin wants to merge 1 commit into
mainfrom
alon/alien-411-publish-from-an-explicit-release-qualification-run

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Summary

  • accept an optional qualification run ID for stable publication
  • require it to be numeric and identify a successful Release qualification run
  • retain all existing manifest source/version/tree, artifact checksum, and image digest verification
  • preserve automatic PR-head discovery for the normal publication path

Validation

  • parsed workflow YAML
  • verified run 30548395023 reports workflow Release qualification and conclusion success
  • its manifest remains subject to the existing exact df0b29fe source/tree checks before publication

Linear: ALIEN-411

exit 1
fi
RUN_ID="$QUALIFICATION_RUN_ID"
HEAD_SHA="$RELEASE_COMMIT"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Qualification source identity is overwritten

When an explicit run ID selects the successful qualification created for a release PR head, this branch replaces that run's source SHA with the distinct merged commit SHA. The subsequent manifest comparison rejects the valid run with Qualified artifact set does not match the merged release tree, and image verification would likewise look for a tag based on the wrong SHA.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 358

Comment:
**Qualification source identity is overwritten**

When an explicit run ID selects the successful qualification created for a release PR head, this branch replaces that run's source SHA with the distinct merged commit SHA. The subsequent manifest comparison rejects the valid run with `Qualified artifact set does not match the merged release tree`, and image verification would likewise look for a tag based on the wrong SHA.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Codex

@greptile-apps

greptile-apps Bot commented Jul 30, 2026

Copy link
Copy Markdown

Greptile Summary

Adds an optional explicit qualification-run selector for stable publication.

  • Exposes the run ID through reusable and manually dispatched workflow inputs.
  • Validates that the input is numeric and names a successful Release qualification run.
  • Retains manifest metadata, artifact checksum, and image digest verification.
  • Preserves automatic qualification-run discovery when no explicit ID is supplied.

Confidence Score: 4/5

This PR should not merge until explicit publication preserves the selected qualification run's actual source SHA.

A normal release qualification records the PR head SHA, but the new explicit-run branch compares it against the distinct merged commit SHA, causing the feature's intended publication path to fail before artifacts can be published.

Files Needing Attention: .github/workflows/release.yml

Important Files Changed

Filename Overview
.github/workflows/release.yml Adds explicit qualification-run selection, but binds validation to the merge commit and therefore rejects the normal PR-head qualification run.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Input[Explicit qualification run ID] --> Validate[Validate successful Release qualification run]
  Validate --> Select[Select run artifacts]
  Select --> Assign[Set HEAD_SHA to merged release commit]
  Assign --> Manifest[Read manifest headSha recorded from qualification source]
  Manifest --> Compare{Manifest headSha equals HEAD_SHA?}
  Compare -->|PR qualification: no| Fail[Reject publication]
  Compare -->|Merged-commit requalification: yes| Verify[Verify checksums and image digests]
Loading

Fix All in Codex

Prompt To Fix All With AI
### Issue 1
.github/workflows/release.yml:358
**Qualification source identity is overwritten**

When an explicit run ID selects the successful qualification created for a release PR head, this branch replaces that run's source SHA with the distinct merged commit SHA. The subsequent manifest comparison rejects the valid run with `Qualified artifact set does not match the merged release tree`, and image verification would likewise look for a tag based on the wrong SHA.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "fix(ci): publish an explicit qualificati..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant