fix(ci): publish an explicit qualification run - #264
Conversation
| exit 1 | ||
| fi | ||
| RUN_ID="$QUALIFICATION_RUN_ID" | ||
| HEAD_SHA="$RELEASE_COMMIT" |
There was a problem hiding this comment.
Qualification source identity is overwritten
When an explicit run ID selects the successful qualification created for a release PR head, this branch replaces that run's source SHA with the distinct merged commit SHA. The subsequent manifest comparison rejects the valid run with Qualified artifact set does not match the merged release tree, and image verification would likewise look for a tag based on the wrong SHA.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 358
Comment:
**Qualification source identity is overwritten**
When an explicit run ID selects the successful qualification created for a release PR head, this branch replaces that run's source SHA with the distinct merged commit SHA. The subsequent manifest comparison rejects the valid run with `Qualified artifact set does not match the merged release tree`, and image verification would likewise look for a tag based on the wrong SHA.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Greptile SummaryAdds an optional explicit qualification-run selector for stable publication.
Confidence Score: 4/5This PR should not merge until explicit publication preserves the selected qualification run's actual source SHA. A normal release qualification records the PR head SHA, but the new explicit-run branch compares it against the distinct merged commit SHA, causing the feature's intended publication path to fail before artifacts can be published. Files Needing Attention: .github/workflows/release.yml
|
| Filename | Overview |
|---|---|
| .github/workflows/release.yml | Adds explicit qualification-run selection, but binds validation to the merge commit and therefore rejects the normal PR-head qualification run. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
Input[Explicit qualification run ID] --> Validate[Validate successful Release qualification run]
Validate --> Select[Select run artifacts]
Select --> Assign[Set HEAD_SHA to merged release commit]
Assign --> Manifest[Read manifest headSha recorded from qualification source]
Manifest --> Compare{Manifest headSha equals HEAD_SHA?}
Compare -->|PR qualification: no| Fail[Reject publication]
Compare -->|Merged-commit requalification: yes| Verify[Verify checksums and image digests]
Prompt To Fix All With AI
### Issue 1
.github/workflows/release.yml:358
**Qualification source identity is overwritten**
When an explicit run ID selects the successful qualification created for a release PR head, this branch replaces that run's source SHA with the distinct merged commit SHA. The subsequent manifest comparison rejects the valid run with `Qualified artifact set does not match the merged release tree`, and image verification would likewise look for a tag based on the wrong SHA.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "fix(ci): publish an explicit qualificati..." | Re-trigger Greptile
Summary
Release qualificationrunValidation
30548395023reports workflowRelease qualificationand conclusionsuccessdf0b29fesource/tree checks before publicationLinear: ALIEN-411