Fix native window initialization crash for Android trimmed captures - #17
Merged
olehkuznetsov merged 1 commit intoJul 23, 2026
Merged
Conversation
During playback of trimmed captures on Android, `Application::Run` would synchronously process the capture's state setup block without giving the Android looper a chance to pump events. Because the `APP_CMD_INIT_WINDOW` callback was never flushed, `AndroidContext::GetWindow()` would return a null pointer. When the state setup block contains `vkCreateAndroidSurfaceKHR`, replay would crash with a fatal error: "Failed to create ANDROID window for use with surface creation. Replay cannot continue." This change actively blocks and pumps the `ALooper` events inside `Application::Run` before executing `ProcessStateSetup`, ensuring the native window is fully bound and avoiding the crash. TAG=agy CONV=ad6b54ea-58c1-4c68-9263-5df32aca3b92
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During playback of trimmed captures on Android,
Application::Runwould synchronously process the capture's state setup block without giving the Android looper a chance to pump events. Because theAPP_CMD_INIT_WINDOWcallback was never flushed,AndroidContext::GetWindow()would return a null pointer. When the state setup block containsvkCreateAndroidSurfaceKHR, replay would crash with a fatal error: "Failed to create ANDROID window for use with surface creation. Replay cannot continue."This change actively blocks and pumps the
ALooperevents insideApplication::Runbefore executingProcessStateSetup, ensuring the native window is fully bound and avoiding the crash.TAG=agy
CONV=ad6b54ea-58c1-4c68-9263-5df32aca3b92