Improve macOS shortcuts and sound controls for v0.3.3 - #2
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebed7a4f57
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| choices | ||
| .into_iter() | ||
| .find(|text| text_width(text) <= cols) | ||
| .unwrap_or(choices[4]) |
There was a problem hiding this comment.
Add a width-safe final shortcut fallback
When the terminal is narrower than 19 cells in English or 18 in Korean, no candidate fits and this fallback returns choices[4] even though it is wider than cols. The caller consequently clips it; for example, at 10 columns the footer becomes F5 Page F, hiding the intended F10 shortcut even though a compact F5 F10 hint would fit. Add shorter fallbacks or otherwise ensure the selected guide fits the supplied width.
Useful? React with 👍 / 👎.
What changed
Why
macOS terminal input does not reliably deliver Alt+P, which made paper mode inaccessible. The previous footer also truncated important controls in smaller windows, and sound toggling was split across F5 and F10.
Validation