Skip to content

Improve macOS shortcuts and sound controls for v0.3.3 - #2

Merged
andy5090 merged 1 commit into
mainfrom
agent/macos-page-width-and-sound-controls
Jul 31, 2026
Merged

Improve macOS shortcuts and sound controls for v0.3.3#2
andy5090 merged 1 commit into
mainfrom
agent/macos-page-width-and-sound-controls

Conversation

@andy5090

Copy link
Copy Markdown
Owner

What changed

  • moved the centered paper/page-width toggle to F5 so it works reliably in macOS terminals
  • retained Alt+P as an alternate shortcut where terminals preserve Alt input
  • consolidated sound controls in the F10 panel and renamed the master toggle to Typing sound
  • made footer shortcut guidance adapt to narrow terminal widths while preserving F5 and F10
  • bumped Termleaf to v0.3.3

Why

macOS terminal input does not reliably deliver Alt+P, which made paper mode inaccessible. The previous footer also truncated important controls in smaller windows, and sound toggling was split across F5 and F10.

Validation

  • cargo fmt --all -- --check
  • cargo test --all-features (81 tests)
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo build --release
  • git diff --check

@andy5090
andy5090 marked this pull request as ready for review July 31, 2026 17:59
@cursor

cursor Bot commented Jul 31, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@andy5090
andy5090 merged commit cadea29 into main Jul 31, 2026
8 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebed7a4f57

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/renderer/terminal.rs
Comment on lines +962 to +965
choices
.into_iter()
.find(|text| text_width(text) <= cols)
.unwrap_or(choices[4])

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add a width-safe final shortcut fallback

When the terminal is narrower than 19 cells in English or 18 in Korean, no candidate fits and this fallback returns choices[4] even though it is wider than cols. The caller consequently clips it; for example, at 10 columns the footer becomes F5 Page F, hiding the intended F10 shortcut even though a compact F5 F10 hint would fit. Add shorter fallbacks or otherwise ensure the selected guide fits the supplied width.

Useful? React with 👍 / 👎.

@andy5090
andy5090 deleted the agent/macos-page-width-and-sound-controls branch July 31, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant