fix 🛠️ (google-maps): deprecate heatmap layer (21.2.x)#33440
Open
stijnbollen wants to merge 9 commits into
Open
fix 🛠️ (google-maps): deprecate heatmap layer (21.2.x)#33440stijnbollen wants to merge 9 commits into
stijnbollen wants to merge 9 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
stijnbollen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The APIs that the heatmap layer is based on have been deprecated for an extended time and Google Maps has removed them.
These changes turn the
map-heatmap-layerinto a no-op and log an error message so that users know what is happening.This change was added to
main(22.x.x) in #33208 by @crisbeto, but is also needed in21.x.xfor those who also use e.g.@ngrxand for now are stuck in21.x.x. Upgrading in21.x.xhas gotten stuck between critical vulnerabilities and errors concerning this deprecated heatmap layer.