Update AGENT.md to match the current engine state#560
Open
Cioscos wants to merge 1 commit into
Open
Conversation
AGENT.md predated several major additions to the engine. Bring it back in sync without duplicating the build/test mechanics already documented in CLAUDE.md and CONTRIBUTING.md: - Describe the engine as Flash/Pro specific (shape selected from the GGUF). - Add ROCm to the list of inference paths that must keep working, and to the per-change testing checklist alongside CUDA. - Add an MTP/speculative-decoding correctness goal. - Harden the macOS safety note: never run the CPU inference path there. - List the five built binaries and the missing source files/dirs in Layout (CUDA/ROCm backends, agent, distributed, SSD streaming, KV store, bench, eval, gguf-tools). - Point Testing at the ds4_test sub-checks and CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENT.mdhad drifted behind the code: it predates the ROCm/Strix Halo backend, the Pro model variant, MTP speculative decoding, and most of the current binaries and test tooling. This PR brings it back in sync while keeping it what it is — a short philosophy/rules document — without duplicating the build/test mechanics already covered byCLAUDE.mdandCONTRIBUTING.md.Changes
ds4_engine_open()time (the code has hadDS4_VARIANT_FLASH/DS4_VARIANT_PROshape tables for a while).make cputhere only to confirm the build compiles. This matches the current guidance inCLAUDE.md.ds4,ds4-server,ds4-bench,ds4-eval,ds4-agent).ds4_cuda.cu/ds4_rocm.cu(+ds4_gpu.h,rocm/*.cuh),ds4_agent.c(+ds4_web.c),ds4_distributed.c,ds4_ssd.c,ds4_kvstore.c(+rax.c),ds4_bench.c/ds4_eval.c,gguf-tools/.ds4_testsub-checks (--server,--logprob-vectors,--long-context,--tool-call-quality,--metal-kernels), pointing atCONTRIBUTING.mdfor details.Docs-only change; no code touched.
🤖 Generated with Claude Code