fix(parquet): propagate nonce generation failures - #1045
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Check the secure-random read used to generate Parquet AES nonces and stop encryption if nonce generation fails.
Why
The encryptor previously ignored the result of
crypto/rand.Read. On Go versions where that function returns an error, encryption could continue with an all-zero or partially filled nonce. Reusing a nonce undermines the security guarantees of both AES-GCM and AES-CTR.The test uses a package-local random-read seam to inject an entropy failure without replacing the process-wide random reader. It covers both supported cipher modes.
Validation
go test ./parquet/internal/encryption