MINOR: Change access modifier of StructVector reallocValidityBuffer#1195
Open
lriggs wants to merge 1 commit into
Open
MINOR: Change access modifier of StructVector reallocValidityBuffer#1195lriggs wants to merge 1 commit into
lriggs wants to merge 1 commit into
Conversation
…vate to protected. This allows subclasses to reallocate the validity buffer independently of the struct elements. Previously, expanding the validity buffer required a full vector reallocation, which could cause an OversizedAllocationException if the child data vectors were already near their capacity.
lriggs
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
selvaganesang
approved these changes
Jun 26, 2026
lriggs
changed the title
|
Thank you for opening a pull request! Please label the PR with one or more of:
Also, add the 'breaking-change' label if appropriate. See CONTRIBUTING.md for details. |
Member
|
What's the use case for subclassing StructVector? |
Contributor
Author
We have a helper class which wraps StructVector to provide more fine grained control. Maybe @selvaganesang can provide some more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Changes the access modifier of reallocValidityBuffer from package-private to protected.
This allows subclasses to reallocate the validity buffer independently of the struct elements. Previously, expanding the validity buffer required a full vector reallocation, which could cause an OversizedAllocationException if the child data vectors were already near their capacity.