[AURON #2005] Upgrade orc to fix incorrect filter pushdown#2097
Open
Flyangz wants to merge 1 commit into
Open
Conversation
Flyangz
changed the title
Member
|
@Flyangz, could you please resolve conflicts? |
weiqingy
reviewed
Jun 22, 2026
| test("test not null filter for orc table") { | ||
| withTable("orc_string_filter") { | ||
| sql("create table orc_string_filter(id int, b string) using orc") | ||
| sql("insert into orc_string_filter values (1, 'abc'), (2, null), (3, 'def')") |
Contributor
There was a problem hiding this comment.
This test reproduces #2005 (the Not / is not null row-group path), but the short values here ('abc', 'def') stay well under ORC's string-statistics truncation threshold, so they don't exercise the #2042 fix (#79, truncated string stats) — that path needs min/max stats long enough to get truncated. Since this PR closes #2042 as well, would it be worth adding a second case with long string values and a comparison/equality predicate, so the truncated-stats fix is locked in against regressions the same way the not-null case is?
SteNicholas
changed the title
Flyangz
force-pushed
the
bugfix/upgrade-orc
branch
from
0839a06 to
bb779c0
Compare
Contributor
Author
@SteNicholas done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2005 #2042
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?
unit and local test