[CALCITE-7634] JoinExpandOrToUnionRule incorrectly expands OR branches with non-equi predicates referencing both join inputs#5069
Conversation
xiedeyantu
changed the title
xuzifu666
left a comment
xuzifu666
left a comment
There was a problem hiding this comment.
Overall it is a nice fix, only left a comment for test.
| * <a href="https://issues.apache.org/jira/browse/CALCITE-7634">[CALCITE-7634] | ||
| * JoinExpandOrToUnionRule incorrectly expands OR branches with non-equi | ||
| * predicates referencing both join inputs</a>. */ | ||
| @Test void testJoinConditionOrExpansionRuleWithCrossInputPredicate() { |
There was a problem hiding this comment.
This only asserts the plan shape, maybe it can't catch the row-dropping bug above. Can we add a quidem test for it? that runs with NULL data and checks the actual result set.
mihaibudiu
added
the
LGTM-will-merge-soon
|
We should merge correctness bugfixes as soon as possible. |
|
I added test in hep.iq. I changed the NOT to IS NOT TRUE. Please take another look. Thanks! @xuzifu666 @mihaibudiu |
|
Thanks for the test; I think everything looks good now. However, the Jira ticket doesn't seem to have a link to this PR yet—you might need to add it manually. @xiedeyantu |
…s with non-equi predicates referencing both join inputs Signed-off-by: xiedeyantu <czjourney@163.com>
|
If there are no other comments, I plan to merge them in a day. |
|
3 participants
Jira Link
CALCITE-7634