chore: resolve audits after DF54.0.0 update to skill#1608
Merged
Conversation
Apply findings from a SKILL.md audit against the current public API: - Pitfall #2: remove the incorrect claim that `.between(...)` needs `lit()`. Its bounds auto-wrap, so `col("a").between(1, 10)` is correct. Update the BETWEEN examples and SQL-to-DataFrame row to drop the redundant `lit()`. - Pitfall apache#6: arithmetic on aggregates inside `aggregate(...)` is fixed in datafusion-python 54; annotate the pitfall as applying to 53 and earlier. - Spark divergence table: drop the `substring` row. Both namespaces are 1-indexed, so listing it in a "behaves differently" table is misleading. - Document APIs not previously covered: `Expr.try_cast`, `DataFrame.cast` mapping form, DataFrame-level `fill_null`, `SessionContext.read_batch` / `read_batches`, `array_contains`, and `DataFrame.col`/`column` for join disambiguation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None. Preparing for release.
Rationale for this change
This primarily updates the skill for checking coverage of this project. It is used by developers only. I also did a drive by correction on mimalloc which creates a segfault using pyarrow 24 (issue #1607)
What changes are included in this PR?
Are there any user-facing changes?
None